Skip to content

Commit e474476

Browse files
authored
Merge pull request #492 from palewire/main
refactor: consolidate mixins into models module
2 parents 5e3de86 + 1111ddc commit e474476

8 files changed

Lines changed: 29 additions & 17 deletions

File tree

datawrapper/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
ValueLabelMode,
7575
ValueLabelPlacement,
7676
)
77-
from datawrapper.charts.mixins import (
77+
from datawrapper.charts.models import (
7878
CustomRangeMixin,
7979
CustomTicksMixin,
8080
GridDisplayMixin,

datawrapper/charts/__init__.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,15 @@
3434
ValueLabelPlacement,
3535
)
3636
from .line import AreaFill, Line, LineChart, LineSymbol, LineValueLabel
37-
from .mixins import (
38-
CustomRangeMixin,
39-
CustomTicksMixin,
40-
GridDisplayMixin,
41-
GridFormatMixin,
42-
)
4337
from .models import (
4438
Annotate,
4539
ColumnFormat,
4640
ColumnFormatList,
41+
CustomRangeMixin,
42+
CustomTicksMixin,
4743
Describe,
44+
GridDisplayMixin,
45+
GridFormatMixin,
4846
Logo,
4947
Publish,
5048
PublishBlocks,

datawrapper/charts/area.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,14 @@
1212
NumberFormat,
1313
PlotHeightMode,
1414
)
15-
from .mixins import (
15+
from .models import (
1616
CustomRangeMixin,
1717
CustomTicksMixin,
1818
GridDisplayMixin,
1919
GridFormatMixin,
20+
RangeAnnotation,
21+
TextAnnotation,
2022
)
21-
from .models import RangeAnnotation, TextAnnotation
2223
from .serializers import (
2324
ColorCategory,
2425
ModelListSerializer,

datawrapper/charts/column.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,14 @@
1313
ValueLabelDisplay,
1414
ValueLabelPlacement,
1515
)
16-
from .mixins import (
16+
from .models import (
1717
CustomRangeMixin,
1818
CustomTicksMixin,
1919
GridDisplayMixin,
2020
GridFormatMixin,
21+
RangeAnnotation,
22+
TextAnnotation,
2123
)
22-
from .models import RangeAnnotation, TextAnnotation
2324
from .serializers import (
2425
ColorCategory,
2526
ModelListSerializer,

datawrapper/charts/line.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,14 @@
2424
SymbolShape,
2525
SymbolStyle,
2626
)
27-
from .mixins import (
27+
from .models import (
2828
CustomRangeMixin,
2929
CustomTicksMixin,
3030
GridDisplayMixin,
3131
GridFormatMixin,
32+
RangeAnnotation,
33+
TextAnnotation,
3234
)
33-
from .models import RangeAnnotation, TextAnnotation
3435
from .serializers import (
3536
ColorCategory,
3637
ModelListSerializer,

datawrapper/charts/models/__init__.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@
99
Sharing,
1010
Visualize,
1111
)
12+
from .mixins import (
13+
CustomRangeMixin,
14+
CustomTicksMixin,
15+
GridDisplayMixin,
16+
GridFormatMixin,
17+
)
1218
from .range_annotations import (
1319
RangeAnnotation,
1420
XLineAnnotation,
@@ -24,7 +30,11 @@
2430
"ColumnFormat",
2531
"ColumnFormatList",
2632
"ConnectorLine",
33+
"CustomRangeMixin",
34+
"CustomTicksMixin",
2735
"Describe",
36+
"GridDisplayMixin",
37+
"GridFormatMixin",
2838
"Logo",
2939
"Publish",
3040
"PublishBlocks",
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
from pydantic import Field
66

7-
from .enums import DateFormat, GridDisplay, NumberFormat
8-
from .serializers import CustomRange, CustomTicks
7+
from ..enums import DateFormat, GridDisplay, NumberFormat
8+
from ..serializers import CustomRange, CustomTicks
99

1010

1111
class GridDisplayMixin:

datawrapper/charts/multiple_column.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,14 @@
2020
ValueLabelDisplay,
2121
ValueLabelPlacement,
2222
)
23-
from .mixins import (
23+
from .models import (
2424
CustomRangeMixin,
2525
CustomTicksMixin,
2626
GridDisplayMixin,
2727
GridFormatMixin,
28+
RangeAnnotation,
29+
TextAnnotation,
2830
)
29-
from .models import RangeAnnotation, TextAnnotation
3031
from .serializers import (
3132
ColorCategory,
3233
ModelListSerializer,

0 commit comments

Comments
 (0)