Merge pull request #2 from cdzombak/cdz/lint

lint

Author: cdzombak

.github/workflows/main.yml

@@ -96,11 +96,21 @@ jobs:
       pull-requests: write
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
-      - name: Super-linter
-        uses: super-linter/super-linter/slim@v7.4.0
+        uses: actions/checkout@v4.2.2
+      - name: Run MegaLinter
+        uses: oxsecurity/megalinter@e08c2b05e3dbc40af4c23f41172ef1e068a7d651 # v8.8.0
         env:
+          # See https://megalinter.io/configuration and .mega-linter.yml
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          APPLY_FIXES_MODE: commit
+      - name: Archive MegaLinter artifacts
+        if: ( !env.ACT && ( success() || failure() ) )
+        uses: actions/upload-artifact@v4.6.2
+        with:
+          name: MegaLinter artifacts
+          path: |
+            megalinter-reports
+            mega-linter.log
 
   docker:
     name: Docker Images
@@ -189,7 +199,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5.5.0
         with:
           go-version: stable
       - name: Go version

.mega-linter.yml

@@ -0,0 +1,21 @@
+# https://megalinter.io/configuration/
+
+---
+APPLY_FIXES: all
+
+DISABLE:
+  - REPOSITORY
+  - SPELL
+DISABLE_LINTERS:
+  - MAKEFILE_CHECKMAKE
+PLUGINS:
+  - https://raw.githubusercontent.com/cdzombak/mega-linter-plugin-dockerfilelint/main/mega-linter-plugin-dockerfilelint/dockerfilelint.megalinter-descriptor.yml
+
+GO_REVIVE_CONFIG_FILE: ".revive.toml"
+JAVASCRIPT_STANDARD_FILTER_REGEX_EXCLUDE: "blurhash\\.js"
+MARKDOWN_MARKDOWNLINT_ARGUMENTS: "--disable MD013"
+
+VALIDATE_ALL_CODEBASE: true
+SHOW_ELAPSED_TIME: false
+FILEIO_REPORTER: false
+PRINT_ALPACA: false

.revive.toml

@@ -0,0 +1,31 @@
+ignoreGeneratedHeader = false
+severity = "warning"
+confidence = 0.8
+errorCode = 0
+warningCode = 0
+
+[rule.blank-imports]
+[rule.context-as-argument]
+[rule.context-keys-type]
+[rule.dot-imports]
+[rule.error-return]
+[rule.error-strings]
+[rule.error-naming]
+[rule.exported]
+[rule.if-return]
+[rule.increment-decrement]
+[rule.var-naming]
+[rule.var-declaration]
+[rule.package-comments]
+	Disabled = true
+[rule.range]
+[rule.receiver-naming]
+[rule.time-naming]
+[rule.unexported-return]
+[rule.indent-error-flow]
+[rule.errorf]
+[rule.empty-block]
+[rule.superfluous-else]
+[rule.unused-parameter]
+[rule.unreachable-code]
+[rule.redefines-builtin-id]

Makefile

@@ -58,11 +58,3 @@ lint: ## Lint all source files in this repository (requires nektos/act: https://
 .PHONY: update-lint
 update-lint: ## Pull updated images supporting the lint target (may fetch >10 GB!)
 	docker pull catthehacker/ubuntu:full-latest
-
-GOLINT_FILES:=$(shell find . -name '*.go' | grep -v /vendor/)
-.PHONY: golint
-golint: ## Lint all .go files with golint
-	@for file in ${GOLINT_FILES} ;  do \
-		echo "$$file" ; \
-		golint $$file ; \
-	done

README.md

@@ -1,3 +1,5 @@
+# gallerygen
+
 ![gallerygen banner](img/gallerygen-banner.png)
 
 **gallerygen** generates a static HTML gallery from a directory of images.

gallerygen.go

@@ -10,7 +10,6 @@ import (
 	_ "image/gif"
 	_ "image/jpeg"
 	_ "image/png"
-	"io"
 	"log"
 	"os"
 	"os/signal"
@@ -252,27 +251,6 @@ func generateHTML(dir Directory, tmpl *template.Template) error {
 	return nil
 }
 
-func copyFile(src, dst string) error {
-	sourceFile, err := os.Open(src)
-	if err != nil {
-		return err
-	}
-	defer sourceFile.Close()
-
-	destFile, err := os.Create(dst)
-	if err != nil {
-		return err
-	}
-	defer destFile.Close()
-
-	_, err = io.Copy(destFile, sourceFile)
-	if err != nil {
-		return err
-	}
-
-	return destFile.Sync()
-}
-
 func watchDirectory(dirPath string, tmpl *template.Template, title string) error {
 	watcher, err := fsnotify.NewWatcher()
 	if err != nil {