Skip to content

Commit 0615ed0

Browse files
authored
Merge pull request #31 from Sampas/issue-26
Issue #26 - Fix implicit type conversion warnings
2 parents fd451ce + f77ec50 commit 0615ed0

1 file changed

Lines changed: 53 additions & 53 deletions

File tree

cmp.c

Lines changed: 53 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -339,13 +339,13 @@ bool cmp_write_integer(cmp_ctx_t *ctx, int64_t d) {
339339
if (d >= 0)
340340
return cmp_write_uinteger(ctx, d);
341341
if (d >= -32)
342-
return cmp_write_nfix(ctx, d);
342+
return cmp_write_nfix(ctx, (int8_t)d);
343343
if (d >= -128)
344-
return cmp_write_s8(ctx, d);
344+
return cmp_write_s8(ctx, (int8_t)d);
345345
if (d >= -32768)
346-
return cmp_write_s16(ctx, d);
346+
return cmp_write_s16(ctx, (int16_t)d);
347347
if (d >= (-2147483647 - 1))
348-
return cmp_write_s32(ctx, (int32_t) d);
348+
return cmp_write_s32(ctx, (int32_t)d);
349349

350350
return cmp_write_s64(ctx, d);
351351
}
@@ -390,13 +390,13 @@ bool cmp_write_u64(cmp_ctx_t *ctx, uint64_t l) {
390390

391391
bool cmp_write_uinteger(cmp_ctx_t *ctx, uint64_t u) {
392392
if (u <= 0x7F)
393-
return cmp_write_pfix(ctx, u);
393+
return cmp_write_pfix(ctx, (uint8_t)u);
394394
if (u <= 0xFF)
395-
return cmp_write_u8(ctx, u);
395+
return cmp_write_u8(ctx, (uint8_t)u);
396396
if (u <= 0xFFFF)
397-
return cmp_write_u16(ctx, u);
397+
return cmp_write_u16(ctx, (uint16_t)u);
398398
if (u <= 0xFFFFFFFF)
399-
return cmp_write_u32(ctx, (uint32_t) u);
399+
return cmp_write_u32(ctx, (uint32_t)u);
400400

401401
return cmp_write_u64(ctx, u);
402402
}
@@ -558,40 +558,40 @@ bool cmp_write_str32(cmp_ctx_t *ctx, const char *data, uint32_t size) {
558558

559559
bool cmp_write_str_marker(cmp_ctx_t *ctx, uint32_t size) {
560560
if (size <= FIXSTR_SIZE)
561-
return cmp_write_fixstr_marker(ctx, size);
561+
return cmp_write_fixstr_marker(ctx, (uint8_t)size);
562562
if (size <= 0xFF)
563-
return cmp_write_str8_marker(ctx, size);
563+
return cmp_write_str8_marker(ctx, (uint8_t)size);
564564
if (size <= 0xFFFF)
565-
return cmp_write_str16_marker(ctx, size);
565+
return cmp_write_str16_marker(ctx, (uint16_t)size);
566566

567567
return cmp_write_str32_marker(ctx, size);
568568
}
569569

570570
bool cmp_write_str_marker_v4(cmp_ctx_t *ctx, uint32_t size) {
571571
if (size <= FIXSTR_SIZE)
572-
return cmp_write_fixstr_marker(ctx, size);
572+
return cmp_write_fixstr_marker(ctx, (uint8_t)size);
573573
if (size <= 0xFFFF)
574-
return cmp_write_str16_marker(ctx, size);
574+
return cmp_write_str16_marker(ctx, (uint16_t)size);
575575

576576
return cmp_write_str32_marker(ctx, size);
577577
}
578578

579579
bool cmp_write_str(cmp_ctx_t *ctx, const char *data, uint32_t size) {
580580
if (size <= FIXSTR_SIZE)
581-
return cmp_write_fixstr(ctx, data, size);
581+
return cmp_write_fixstr(ctx, data, (uint8_t)size);
582582
if (size <= 0xFF)
583-
return cmp_write_str8(ctx, data, size);
583+
return cmp_write_str8(ctx, data, (uint8_t)size);
584584
if (size <= 0xFFFF)
585-
return cmp_write_str16(ctx, data, size);
585+
return cmp_write_str16(ctx, data, (uint16_t)size);
586586

587587
return cmp_write_str32(ctx, data, size);
588588
}
589589

590590
bool cmp_write_str_v4(cmp_ctx_t *ctx, const char *data, uint32_t size) {
591591
if (size <= FIXSTR_SIZE)
592-
return cmp_write_fixstr(ctx, data, size);
592+
return cmp_write_fixstr(ctx, data, (uint8_t)size);
593593
if (size <= 0xFFFF)
594-
return cmp_write_str16(ctx, data, size);
594+
return cmp_write_str16(ctx, data, (uint16_t)size);
595595

596596
return cmp_write_str32(ctx, data, size);
597597
}
@@ -677,18 +677,18 @@ bool cmp_write_bin32(cmp_ctx_t *ctx, const void *data, uint32_t size) {
677677

678678
bool cmp_write_bin_marker(cmp_ctx_t *ctx, uint32_t size) {
679679
if (size <= 0xFF)
680-
return cmp_write_bin8_marker(ctx, size);
680+
return cmp_write_bin8_marker(ctx, (uint8_t)size);
681681
if (size <= 0xFFFF)
682-
return cmp_write_bin16_marker(ctx, size);
682+
return cmp_write_bin16_marker(ctx, (uint16_t)size);
683683

684684
return cmp_write_bin32_marker(ctx, size);
685685
}
686686

687687
bool cmp_write_bin(cmp_ctx_t *ctx, const void *data, uint32_t size) {
688688
if (size <= 0xFF)
689-
return cmp_write_bin8(ctx, data, size);
689+
return cmp_write_bin8(ctx, data, (uint8_t)size);
690690
if (size <= 0xFFFF)
691-
return cmp_write_bin16(ctx, data, size);
691+
return cmp_write_bin16(ctx, data, (uint16_t)size);
692692

693693
return cmp_write_bin32(ctx, data, size);
694694
}
@@ -729,9 +729,9 @@ bool cmp_write_array32(cmp_ctx_t *ctx, uint32_t size) {
729729

730730
bool cmp_write_array(cmp_ctx_t *ctx, uint32_t size) {
731731
if (size <= FIXARRAY_SIZE)
732-
return cmp_write_fixarray(ctx, size);
732+
return cmp_write_fixarray(ctx, (uint8_t)size);
733733
if (size <= 0xFFFF)
734-
return cmp_write_array16(ctx, size);
734+
return cmp_write_array16(ctx, (uint16_t)size);
735735

736736
return cmp_write_array32(ctx, size);
737737
}
@@ -772,9 +772,9 @@ bool cmp_write_map32(cmp_ctx_t *ctx, uint32_t size) {
772772

773773
bool cmp_write_map(cmp_ctx_t *ctx, uint32_t size) {
774774
if (size <= FIXMAP_SIZE)
775-
return cmp_write_fixmap(ctx, size);
775+
return cmp_write_fixmap(ctx, (uint8_t)size);
776776
if (size <= 0xFFFF)
777-
return cmp_write_map16(ctx, size);
777+
return cmp_write_map16(ctx, (uint16_t)size);
778778

779779
return cmp_write_map32(ctx, size);
780780
}
@@ -986,9 +986,9 @@ bool cmp_write_ext_marker(cmp_ctx_t *ctx, int8_t tp, uint32_t sz) {
986986
if (sz == 16)
987987
return cmp_write_fixext16_marker(ctx, tp);
988988
if (sz <= 0xFF)
989-
return cmp_write_ext8_marker(ctx, tp, sz);
989+
return cmp_write_ext8_marker(ctx, tp, (uint8_t)sz);
990990
if (sz <= 0xFFFF)
991-
return cmp_write_ext16_marker(ctx, tp, sz);
991+
return cmp_write_ext16_marker(ctx, tp, (uint16_t)sz);
992992

993993
return cmp_write_ext32_marker(ctx, tp, sz);
994994
}
@@ -1005,9 +1005,9 @@ bool cmp_write_ext(cmp_ctx_t *ctx, int8_t tp, uint32_t sz, const void *data) {
10051005
if (sz == 16)
10061006
return cmp_write_fixext16(ctx, tp, data);
10071007
if (sz <= 0xFF)
1008-
return cmp_write_ext8(ctx, tp, sz, data);
1008+
return cmp_write_ext8(ctx, tp, (uint8_t)sz, data);
10091009
if (sz <= 0xFFFF)
1010-
return cmp_write_ext16(ctx, tp, sz, data);
1010+
return cmp_write_ext16(ctx, tp, (uint16_t)sz, data);
10111011

10121012
return cmp_write_ext32(ctx, tp, sz, data);
10131013
}
@@ -1017,27 +1017,27 @@ bool cmp_write_object(cmp_ctx_t *ctx, cmp_object_t *obj) {
10171017
case CMP_TYPE_POSITIVE_FIXNUM:
10181018
return cmp_write_pfix(ctx, obj->as.u8);
10191019
case CMP_TYPE_FIXMAP:
1020-
return cmp_write_fixmap(ctx, obj->as.map_size);
1020+
return cmp_write_fixmap(ctx, (uint8_t)obj->as.map_size);
10211021
case CMP_TYPE_FIXARRAY:
1022-
return cmp_write_fixarray(ctx, obj->as.array_size);
1022+
return cmp_write_fixarray(ctx, (uint8_t)obj->as.array_size);
10231023
case CMP_TYPE_FIXSTR:
1024-
return cmp_write_fixstr_marker(ctx, obj->as.str_size);
1024+
return cmp_write_fixstr_marker(ctx, (uint8_t)obj->as.str_size);
10251025
case CMP_TYPE_NIL:
10261026
return cmp_write_nil(ctx);
10271027
case CMP_TYPE_BOOLEAN:
10281028
if (obj->as.boolean)
10291029
return cmp_write_true(ctx);
10301030
return cmp_write_false(ctx);
10311031
case CMP_TYPE_BIN8:
1032-
return cmp_write_bin8_marker(ctx, obj->as.bin_size);
1032+
return cmp_write_bin8_marker(ctx, (uint8_t)obj->as.bin_size);
10331033
case CMP_TYPE_BIN16:
1034-
return cmp_write_bin16_marker(ctx, obj->as.bin_size);
1034+
return cmp_write_bin16_marker(ctx, (uint16_t)obj->as.bin_size);
10351035
case CMP_TYPE_BIN32:
10361036
return cmp_write_bin32_marker(ctx, obj->as.bin_size);
10371037
case CMP_TYPE_EXT8:
1038-
return cmp_write_ext8_marker(ctx, obj->as.ext.type, obj->as.ext.size);
1038+
return cmp_write_ext8_marker(ctx, obj->as.ext.type, (uint8_t)obj->as.ext.size);
10391039
case CMP_TYPE_EXT16:
1040-
return cmp_write_ext16_marker(ctx, obj->as.ext.type, obj->as.ext.size);
1040+
return cmp_write_ext16_marker(ctx, obj->as.ext.type, (uint16_t)obj->as.ext.size);
10411041
case CMP_TYPE_EXT32:
10421042
return cmp_write_ext32_marker(ctx, obj->as.ext.type, obj->as.ext.size);
10431043
case CMP_TYPE_FLOAT:
@@ -1071,17 +1071,17 @@ bool cmp_write_object(cmp_ctx_t *ctx, cmp_object_t *obj) {
10711071
case CMP_TYPE_FIXEXT16:
10721072
return cmp_write_fixext16_marker(ctx, obj->as.ext.type);
10731073
case CMP_TYPE_STR8:
1074-
return cmp_write_str8_marker(ctx, obj->as.str_size);
1074+
return cmp_write_str8_marker(ctx, (uint8_t)obj->as.str_size);
10751075
case CMP_TYPE_STR16:
1076-
return cmp_write_str16_marker(ctx, obj->as.str_size);
1076+
return cmp_write_str16_marker(ctx, (uint16_t)obj->as.str_size);
10771077
case CMP_TYPE_STR32:
10781078
return cmp_write_str32_marker(ctx, obj->as.str_size);
10791079
case CMP_TYPE_ARRAY16:
1080-
return cmp_write_array16(ctx, obj->as.array_size);
1080+
return cmp_write_array16(ctx, (uint16_t)obj->as.array_size);
10811081
case CMP_TYPE_ARRAY32:
10821082
return cmp_write_array32(ctx, obj->as.array_size);
10831083
case CMP_TYPE_MAP16:
1084-
return cmp_write_map16(ctx, obj->as.map_size);
1084+
return cmp_write_map16(ctx, (uint16_t)obj->as.map_size);
10851085
case CMP_TYPE_MAP32:
10861086
return cmp_write_map32(ctx, obj->as.map_size);
10871087
case CMP_TYPE_NEGATIVE_FIXNUM:
@@ -1097,27 +1097,27 @@ bool cmp_write_object_v4(cmp_ctx_t *ctx, cmp_object_t *obj) {
10971097
case CMP_TYPE_POSITIVE_FIXNUM:
10981098
return cmp_write_pfix(ctx, obj->as.u8);
10991099
case CMP_TYPE_FIXMAP:
1100-
return cmp_write_fixmap(ctx, obj->as.map_size);
1100+
return cmp_write_fixmap(ctx, (uint8_t)obj->as.map_size);
11011101
case CMP_TYPE_FIXARRAY:
1102-
return cmp_write_fixarray(ctx, obj->as.array_size);
1102+
return cmp_write_fixarray(ctx, (uint8_t)obj->as.array_size);
11031103
case CMP_TYPE_FIXSTR:
1104-
return cmp_write_fixstr_marker(ctx, obj->as.str_size);
1104+
return cmp_write_fixstr_marker(ctx, (uint8_t)obj->as.str_size);
11051105
case CMP_TYPE_NIL:
11061106
return cmp_write_nil(ctx);
11071107
case CMP_TYPE_BOOLEAN:
11081108
if (obj->as.boolean)
11091109
return cmp_write_true(ctx);
11101110
return cmp_write_false(ctx);
11111111
case CMP_TYPE_BIN8:
1112-
return cmp_write_bin8_marker(ctx, obj->as.bin_size);
1112+
return cmp_write_bin8_marker(ctx, (uint8_t)obj->as.bin_size);
11131113
case CMP_TYPE_BIN16:
1114-
return cmp_write_bin16_marker(ctx, obj->as.bin_size);
1114+
return cmp_write_bin16_marker(ctx, (uint16_t)obj->as.bin_size);
11151115
case CMP_TYPE_BIN32:
11161116
return cmp_write_bin32_marker(ctx, obj->as.bin_size);
11171117
case CMP_TYPE_EXT8:
1118-
return cmp_write_ext8_marker(ctx, obj->as.ext.type, obj->as.ext.size);
1118+
return cmp_write_ext8_marker(ctx, obj->as.ext.type, (uint8_t)obj->as.ext.size);
11191119
case CMP_TYPE_EXT16:
1120-
return cmp_write_ext16_marker(ctx, obj->as.ext.type, obj->as.ext.size);
1120+
return cmp_write_ext16_marker(ctx, obj->as.ext.type, (uint16_t)obj->as.ext.size);
11211121
case CMP_TYPE_EXT32:
11221122
return cmp_write_ext32_marker(ctx, obj->as.ext.type, obj->as.ext.size);
11231123
case CMP_TYPE_FLOAT:
@@ -1151,15 +1151,15 @@ bool cmp_write_object_v4(cmp_ctx_t *ctx, cmp_object_t *obj) {
11511151
case CMP_TYPE_FIXEXT16:
11521152
return cmp_write_fixext16_marker(ctx, obj->as.ext.type);
11531153
case CMP_TYPE_STR16:
1154-
return cmp_write_str16_marker(ctx, obj->as.str_size);
1154+
return cmp_write_str16_marker(ctx, (uint16_t)obj->as.str_size);
11551155
case CMP_TYPE_STR32:
11561156
return cmp_write_str32_marker(ctx, obj->as.str_size);
11571157
case CMP_TYPE_ARRAY16:
1158-
return cmp_write_array16(ctx, obj->as.array_size);
1158+
return cmp_write_array16(ctx, (uint16_t)obj->as.array_size);
11591159
case CMP_TYPE_ARRAY32:
11601160
return cmp_write_array32(ctx, obj->as.array_size);
11611161
case CMP_TYPE_MAP16:
1162-
return cmp_write_map16(ctx, obj->as.map_size);
1162+
return cmp_write_map16(ctx, (uint16_t)obj->as.map_size);
11631163
case CMP_TYPE_MAP32:
11641164
return cmp_write_map32(ctx, obj->as.map_size);
11651165
case CMP_TYPE_NEGATIVE_FIXNUM:
@@ -1923,7 +1923,7 @@ bool cmp_read_ext8_marker(cmp_ctx_t *ctx, int8_t *type, uint8_t *size) {
19231923
}
19241924

19251925
*type = obj.as.ext.type;
1926-
*size = obj.as.ext.size;
1926+
*size = (uint8_t)obj.as.ext.size;
19271927

19281928
return true;
19291929
}
@@ -1951,7 +1951,7 @@ bool cmp_read_ext16_marker(cmp_ctx_t *ctx, int8_t *type, uint16_t *size) {
19511951
}
19521952

19531953
*type = obj.as.ext.type;
1954-
*size = obj.as.ext.size;
1954+
*size = (uint16_t)obj.as.ext.size;
19551955

19561956
return true;
19571957
}

0 commit comments

Comments
 (0)