Commit bdb3146
committed
refactor: move charge port and valet to switches, add exists_fn
Per review feedback on Hyundai-Kia-Connect#1647:
- Charge port: replace open/close buttons with single switch
(value_fn=ev_charge_port_door_is_open, on=open, off=close)
- Valet mode: add as switch (value_fn=valet_mode_active)
instead of start/stop buttons
- Windows (open/close/vent): keep as buttons — 3-state
(closed/vent/open) doesn't fit switch on/off
- Hazard lights: keep as buttons (fire-and-forget, no state)
- Add exists_fn to HyundaiKiaButtonDescription, remove hardcoded
if-else checks from async_setup_entry
- Remove charge port and valet button translations, add switch ones1 parent 2a745fc commit bdb3146
4 files changed
Lines changed: 41 additions & 59 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
| |||
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | 37 | | |
48 | 38 | | |
49 | 39 | | |
50 | 40 | | |
51 | 41 | | |
| 42 | + | |
52 | 43 | | |
53 | 44 | | |
54 | 45 | | |
55 | 46 | | |
56 | 47 | | |
57 | 48 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
| 49 | + | |
70 | 50 | | |
71 | 51 | | |
72 | 52 | | |
73 | 53 | | |
74 | 54 | | |
75 | 55 | | |
| 56 | + | |
76 | 57 | | |
77 | 58 | | |
78 | 59 | | |
79 | 60 | | |
80 | 61 | | |
81 | 62 | | |
| 63 | + | |
82 | 64 | | |
83 | 65 | | |
84 | 66 | | |
85 | 67 | | |
86 | 68 | | |
87 | 69 | | |
| 70 | + | |
88 | 71 | | |
89 | 72 | | |
90 | 73 | | |
| |||
99 | 82 | | |
100 | 83 | | |
101 | 84 | | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
113 | 89 | | |
114 | 90 | | |
115 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
439 | 439 | | |
440 | 440 | | |
441 | 441 | | |
442 | | - | |
443 | | - | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | 442 | | |
449 | 443 | | |
450 | 444 | | |
451 | 445 | | |
452 | 446 | | |
453 | 447 | | |
454 | | - | |
455 | | - | |
456 | | - | |
457 | | - | |
458 | | - | |
459 | | - | |
460 | 448 | | |
461 | 449 | | |
462 | 450 | | |
| |||
505 | 493 | | |
506 | 494 | | |
507 | 495 | | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
508 | 502 | | |
509 | 503 | | |
510 | 504 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
138 | 156 | | |
139 | 157 | | |
140 | 158 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
745 | 745 | | |
746 | 746 | | |
747 | 747 | | |
748 | | - | |
749 | | - | |
750 | | - | |
751 | | - | |
752 | | - | |
753 | | - | |
754 | 748 | | |
755 | 749 | | |
756 | 750 | | |
757 | 751 | | |
758 | 752 | | |
759 | 753 | | |
760 | | - | |
761 | | - | |
762 | | - | |
763 | | - | |
764 | | - | |
765 | | - | |
766 | 754 | | |
767 | 755 | | |
768 | 756 | | |
| |||
811 | 799 | | |
812 | 800 | | |
813 | 801 | | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
814 | 808 | | |
815 | 809 | | |
816 | 810 | | |
| |||
0 commit comments