-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathopenpr_D_v3_1.txt
More file actions
496 lines (448 loc) · 24.8 KB
/
Copy pathopenpr_D_v3_1.txt
File metadata and controls
496 lines (448 loc) · 24.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
====================================================================================================
CASE D PR #36621 (open-pr, v3.1 prompt)
file: Mathlib/Topology/Category/TopPair.lean line: 15.0
reviewer: @vlad902 on 2026-03-15T11:40:51Z
advice_kind: module-structure / file header
prompt_tokens: 6140 completion_tokens: 2850
HUMAN reviewer (ground truth):
> `#min_imports` gives a much smaller set of imports you could replace this with. Also you are not using the new module structure, look at another file and copy its header structure (e.g. add `module` at the top, these will be `public` imports, and add a `@[expose] public section` below.)
====================================================================================================
[SYSTEM]
----------------------------------------------------------------------------------------------------
You are an expert reviewer for the Lean 4 / mathlib4 mathematical library. Given a NEW code hunk from an open pull request and a set of historically retrieved (past_hunk, past_comment) pairs, your job is to identify which past reviewer feedback would also apply to the new hunk.
Two failure modes are equally bad and you must avoid BOTH:
(X) "axis-miss" false positive: a past comment and the new code look similar on the surface, but the past reviewer's concern is not present in the new hunk. (Example: past comment is about `ppSpace` formatting, new hunk's actual problem is "this whole function shouldn't return a string".)
(Y) "over-refusal" false negative: a candidate IS genuinely applicable, but you refuse because its concern axis didn't appear in your initial inventory. (Example: you forgot to list `refactor-simplify` for a proof hunk, then declined a candidate that correctly suggests using a higher-level lemma.)
A correct silent output is more valuable than a confident wrong-axis answer, but losing a clearly-applicable candidate is also a real cost.
Read carefully before producing JSON. Follow the four steps below in order.
STEP 1 — STRUCTURAL + SEMANTIC READING OF THE NEW HUNK.
1a. Parse the code shape: tactic-mode vs term-mode, declaration kind (`def` / `theorem` / `lemma` / `instance` / `class` / `structure` / `abbrev` / `syntax` / `notation`), attributes (`@[simp]`, `@[to_additive]`, `@[deprecated]`, `@[ext]`, `@[fun_prop]`, `@[reassoc]`, …), universe parameters, implicit/explicit binders, docstring style, proof tactics used.
1b. Inventory what *could* be criticized about THIS specific hunk. Pick as many as apply from this list of "concern axes":
- correctness-bug (code doesn't typecheck / is logically wrong)
- naming (lemma/def name doesn't follow conventions)
- docstring (missing, unclear, typo, wrong phrasing)
- attribute (missing/wrong `@[simp]` / `@[to_additive]` …)
- style-syntax (`fun x ↦` vs `fun x =>`, `by use _; exact _` vs `⟨_, _⟩`, whitespace/`ppSpace`, notation preference)
- proof-golf (the proof tactics could be shorter/nicer)
- refactor-simplify (same statement provable with less machinery, e.g. use a dedicated higher-level lemma instead of manual rewriting)
- generalize-signature (hypotheses too strong; remove/weaken a typeclass)
- design-smell-architectural (this API shape is wrong; returning a string, unnecessary instance, redundant definition, etc.)
- imports-module (superfluous imports, module structure)
- namespace-organization (`_root_`, namespace boundary, file placement)
- automation-tactic (should use / should teach `aesop_cat`, `gcongr`, `positivity`, etc.)
- instance-diamond (this instance creates an ambiguity / defeq diamond with another)
- unify-with-existing (a similar definition/lemma already exists)
- junk-value (docstring should note behavior at the "undefined" input; handled via `0`/`⊥`/`⊤`)
1c. DEFAULT-INCLUDE RULE. For ANY non-trivial proof or definition hunk (i.e. not a pure-imports/notation/file-header hunk), you MUST include the following axes in your plausible list unless the hunk is so trivial that they cannot apply: `refactor-simplify`, `proof-golf`, `docstring`, `naming`. These are the most common reviewer concerns; gating them out by omission caused real misses in past evaluation. Adding them is cheap; they only trigger a promotion if a candidate also matches.
1d. List the concerns that PLAUSIBLY apply to the new hunk (including the defaults from 1c). If none from outside 1c are obviously present, that is fine — the defaults still cover proof/definition hunks.
STEP 2 — PER-CANDIDATE CONCERN CLASSIFICATION.
For EACH candidate, identify which concern axis (from the same list) the past reviewer's comment was about. Read the past comment carefully: the reviewer's *words* (not the past code) tell you the concern axis. If a past comment ships a `suggestion` code block, that block is evidence for what the reviewer wanted changed — but the axis of concern comes from the prose around it. Ignore candidates whose past comment is pure bikeshed or where you cannot identify a clear concern.
STEP 3 — AXIS MATCH + APPLICABILITY CHECK.
A candidate is eligible for `strong_matches` ONLY if BOTH:
(a) Its axis (from step 2) is among the new hunk's plausible concerns (from step 1d), OR you can clearly justify (in `applies_because`) why this axis IS present in the new hunk after all — in which case ADD that axis to `new_hunk_plausible_concerns` in your output. Late additions are allowed but should be the exception, not the rule.
(b) You can write a concrete adaptation that a Lean/mathlib reviewer would plausibly post on the new hunk *today*, given what is visible in the hunk.
Before promoting, write — in the JSON output, per match — a `why_might_not_apply` field giving the strongest counter-argument against promotion (one short sentence).
DEMOTION RULE (this is the #1 axis-miss-prevention lever):
If your counter-argument names a SPECIFIC PROPERTY of the new hunk that would make the past advice not apply or already-followed — e.g. "the new code already uses term-mode", "the lemma is already named correctly", "the import is actually used at line X", "the new code does not declare an instance, so the diamond risk does not apply" — then DEMOTE to `weak_observations` instead of promoting.
Only PROMOTE if the counter-argument is generic doubt that does NOT identify a specific reason the new hunk evades the past advice — e.g. "this is partly stylistic preference", "the user may have intended this", "I cannot verify without seeing more context". Generic doubt does not block promotion; specific evasion does.
Cross-candidate synthesis is allowed: if candidate X establishes that an identifier in the new hunk is a `class`, and candidate Y shows the preferred term-mode `instance := ⟨...⟩` template, they jointly support a promotion. List both in `supporting_past_prs` and still produce one `why_might_not_apply`.
STEP 4 — CONFIDENCE AND OUTPUT.
Confidence scale:
- "high" — ≥1 strong match survives step 3 AND the adaptation is a near-verbatim application of a past comment; the counter-argument is generic.
- "medium" — ≥1 strong match survives step 3 BUT needs adaptation or synthesis; counter-argument is generic doubt rather than specific evasion.
- "low" — no candidate survives step 3; only stylistic patterns worth mentioning as `weak_observations`.
- "none" — retrieved pool's concerns don't match anything plausible about the new hunk; state this and stop.
Output JSON ONLY, matching this exact schema:
{
"new_hunk_plausible_concerns": [<axis labels from Step 1d, plus any added in Step 3a>],
"summary": "<one sentence describing what we found>",
"confidence": "high"|"medium"|"low"|"none",
"strong_matches": [
{
"past_pr": <int>,
"past_file": "<string>",
"past_concern_axis": "<axis label from the list>",
"past_comment_excerpt": "<verbatim short quote from the past comment OR the relevant snippet from its suggestion block>",
"applies_because": "<one or two sentences linking past code/comment to the new hunk's structure AND explaining why the concern axis matches>",
"suggested_adaptation": "<one sentence on what the reviewer might say on the new hunk>",
"why_might_not_apply": "<one short sentence — strongest counter-argument against this promotion>",
"supporting_past_prs": [<int>, ...]
}
],
"weak_observations": [
{
"observation": "<short string>",
"axis": "<axis label>",
"supporting_past_prs": [<int>, ...]
}
]
}
Quote short — under 40 words per excerpt. Do not invent axis labels outside the list.
[USER]
----------------------------------------------------------------------------------------------------
NEW HUNK from open PR #36621 (file: Mathlib/Topology/Category/TopPair.lean):
```
@@ -0,0 +1,163 @@
+/-
+Copyright (c) 2026 Jakob Scharmberg. All rights reserved.
+Released under Apache 2.0 license as described in the file LICENSE.
+Authors: Jakob Scharmberg
+-/
+import Mathlib.Topology.Defs.Basic
+import Mathlib.Topology.Category.TopCat.Basic
+import Mathlib.Topology.Defs.Induced
+import Mathlib.CategoryTheory.Category.Basic
+import Mathlib.CategoryTheory.CommSq
+import Mathlib.Topology.Homotopy.Basic
+import Mathlib.Topology.Category.TopCat.Limits.Basic
+import Mathlib.CategoryTheory.Limits.Shapes.BinaryProducts
+import Mathlib.Topology.UnitInterval
+import Mathlib.Topology.Category.TopCat.Limits.Basic
```
RETRIEVED CANDIDATES (top-20 by hunk-embedding similarity, sorted by sim desc):
--- candidate 1 (sim=0.728, past_pr=#15417, file=Mathlib/AlgebraicTopology/TopologicalSimplex.lean) ---
PAST HUNK:
```
@@ -82,6 +83,7 @@ def toTop : SimplexCategory ⥤ TopCat where
funext i
dsimp
simp only [comp_apply, TopCat.coe_of_of, ContinuousMap.coe_mk, coe_toTopMap]
+ classical
```
PAST COMMENT (from reviewer):
```suggestion
```
--- candidate 2 (sim=0.725, past_pr=#3802, file=Mathlib/Topology/Category/Top/Limits/Pullbacks.lean) ---
PAST HUNK:
```
@@ -370,43 +390,147 @@ theorem pullback_fst_image_snd_preimage (f : X ⟶ Z) (g : Y ⟶ Z) (U : Set Y)
... [9 lines above hidden]
#align Top.pullback_fst_image_snd_preimage TopCat.pullback_fst_image_snd_preimage
end Pullback
-theorem coinduced_of_isColimit {F : J ⥤ TopCat.{max v u}} (c : Cocone F) (hc : IsColimit c) :
- c.pt.TopologicalSpace = ⨆ j, (F.obj j).TopologicalSpace.coinduced (c.ι.app j) := by
- let homeo := homeo_of_iso (hc.cocone_point_unique_up_to_iso (colimit_cocone_is_colimit F))
+/-- The binary coproduct cofan in `TopCat`. -/
+protected def binaryCofan (X Y : TopCat.{u}) : BinaryCofan X Y :=
+ BinaryCofan.mk (⟨Sum.inl, by continuity⟩ : X ⟶ TopCat.of (Sum X Y)) ⟨Sum.inr, by continuity⟩
+#align Top.binary_cofan TopCat.binaryCofan
+
+/-- The constructed binary coproduct cofan in `TopCat` is the coproduct. -/
```
PAST COMMENT (from reviewer):
Are the next 100 lines new? Or did this move in ml3 during the porting of this file? I don't see it when comparing to the mathport output that this port started from...
--- candidate 3 (sim=0.722, past_pr=#15417, file=Mathlib/AlgebraicTopology/TopologicalSimplex.lean) ---
PAST HUNK:
```
@@ -73,6 +73,7 @@ def toTop : SimplexCategory ⥤ TopCat where
ext f
apply toTopObj.ext
funext i
+ classical
```
PAST COMMENT (from reviewer):
I don't understand: in the current version, `classical` is still there, and can be removed. Did you forget to push?
--- candidate 4 (sim=0.713, past_pr=#4593, file=Mathlib/Topology/Order/FrameAdjunction.lean) ---
PAST HUNK:
```
+/-
+Copyright (c) 2023 Anne Baanen, Sam v. Gool, Leo Mayer, Brendan S. Murphy. All rights reserved.
+Released under Apache 2.0 license as described in the file LICENSE.
+Authors: Anne Baanen, Sam v. Gool, Leo Mayer, Brendan S. Murphy
+-/
+import Mathlib.Order.CompleteBooleanAlgebra
+import Mathlib.Topology.Basic
+import Mathlib.Topology.Bases
+import Mathlib.Topology.Sets.Opens
+import Mathlib.CategoryTheory.Adjunction.Basic
+import Mathlib.CategoryTheory.Opposites
+import Mathlib.Topology.Category.TopCat.Basic
+import Mathlib.Order.Category.FrmCat
```
PAST COMMENT (from reviewer):
Looks like we only need the last import, and it provides the rest transitively.
```suggestion
import Mathlib.Order.Category.FrmCat
```
--- candidate 5 (sim=0.711, past_pr=#31943, file=Mathlib/AlgebraicTopology/FundamentalGroupoid/Product.lean) ---
PAST HUNK:
```
@@ -181,7 +181,7 @@ def prodIso : CategoryTheory.Grpd.of (πₓ A × πₓ B) ≅ πₓ (TopCat.of (
have : Path.Homotopic.projLeft ((prodToProdTop A B).map (f₀, f₁)) = f₀ ∧
Path.Homotopic.projRight ((prodToProdTop A B).map (f₀, f₁)) = f₁ :=
And.intro (Path.Homotopic.projLeft_prod f₀ f₁) (Path.Homotopic.projRight_prod f₀ f₁)
- simpa
+ aesop_cat
```
PAST COMMENT (from reviewer):
```suggestion
cat_disch
```
--- candidate 6 (sim=0.710, past_pr=#24777, file=Mathlib/CategoryTheory/MorphismProperty/TransfiniteComposition.lean) ---
PAST HUNK:
```
@@ -3,9 +3,10 @@ Copyright (c) 2024 Joël Riou. All rights reserved.
Released under Apache 2.0 license as described in the file LICENSE.
Authors: Joël Riou
-/
-import Mathlib.CategoryTheory.Limits.Constructions.EventuallyConstant
import Mathlib.CategoryTheory.MorphismProperty.Composition
+import Mathlib.CategoryTheory.MorphismProperty.Limits
import Mathlib.CategoryTheory.Limits.Shapes.Preorder.TransfiniteCompositionOfShape
+import Mathlib.CategoryTheory.Limits.Connected
import Mathlib.Order.Shrink
import Mathlib.Order.Interval.Set.SuccOrder
import Mathlib.Logic.UnivLE
```
PAST COMMENT (from reviewer):
```suggestion
import Mathlib.CategoryTheory.Limits.Connected
import Mathlib.CategoryTheory.Limits.Shapes.Preorder.TransfiniteCompositionOfShape
import Mathlib.CategoryTheory.MorphismProperty.Limits
import Mathlib.Order.Interval.Set.SuccOrder
import Mathlib.Order.Shrink
```
--- candidate 7 (sim=0.707, past_pr=#11727, file=Mathlib/Condensed/TopComparison.lean) ---
PAST HUNK:
```
@@ -30,8 +30,8 @@ universe w w' v u
open CategoryTheory Opposite Limits regularCoverage ContinuousMap
-variable {C : Type u} [Category.{v} C] (G : C ⥤ TopCat.{v})
```
PAST COMMENT (from reviewer):
I don't think this is necessarily more general; omitting `.{}` means that a universe metavariable is used instead, which could potentially be populated with something *less* general. Could you keep the explicit universe names here (perhaps using more of them) to ensure the generality is what you intend?
--- candidate 8 (sim=0.707, past_pr=#17142, file=Mathlib/Geometry/Manifold/ChartedSpace.lean) ---
PAST HUNK:
```
@@ -4,6 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
Authors: Sébastien Gouëzel
-/
import Mathlib.Topology.PartialHomeomorph
+import Mathlib.Topology.Connected.PathConnected
```
PAST COMMENT (from reviewer):
Pointing out for later reviewers: this is where the import increase is coming from.
--- candidate 9 (sim=0.705, past_pr=#2508, file=Mathlib/Topology/Order/ScottTopology.lean) ---
PAST HUNK:
```
@@ -0,0 +1,439 @@
... [3 lines above hidden]
+Released under Apache 2.0 license as described in the file LICENSE.
+Authors: Christopher Hoskin
+-/
+
+import Mathlib.Logic.Equiv.Defs
+import Mathlib.Order.Directed
+import Mathlib.Order.UpperLower.Basic
+import Mathlib.Topology.Basic
+import Mathlib.Topology.ContinuousFunction.Basic
+import Mathlib.Topology.Order
+import Mathlib.Topology.Order.Lattice
+import Mathlib.Topology.Order.UpperLowerSetTopology
+import Mathlib.Topology.Order.LowerUpperTopology
```
PAST COMMENT (from reviewer):
Can you trim down the imports? Only a few are actually needed.
--- candidate 10 (sim=0.701, past_pr=#4076, file=Mathlib/Topology/Category/Top/Limits/Konig.lean) ---
PAST HUNK:
```
@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
Authors: Kyle Miller
! This file was ported from Lean 3 source module topology.category.Top.limits.konig
-! leanprover-community/mathlib commit 8195826f5c428fc283510bc67303dd4472d78498
+! leanprover-community/mathlib commit 178a32653e369dce2da68dc6b2694e385d484ef1
```
PAST COMMENT (from reviewer):
Same comment here. I think these two files should be in a separate PR to this one, as the porting story is rather more clouded, and the dashboard has nothing helpful to show.
--- candidate 11 (sim=0.699, past_pr=#2145, file=test/Continuity.lean) ---
PAST HUNK:
```
@@ -0,0 +1,22 @@
+import Mathlib.Topology.Basic
```
PAST COMMENT (from reviewer):
I think it's worth a note in a comment that this is not a port of https://github.com/leanprover-community/mathlib/blob/master/test/continuity.lean (yet)
--- candidate 12 (sim=0.695, past_pr=#22827, file=Mathlib/Topology/Constructions/SumProd.lean) ---
PAST HUNK:
```
@@ -0,0 +1,987 @@
+/-
+Copyright (c) 2017 Johannes Hölzl. All rights reserved.
+Released under Apache 2.0 license as described in the file LICENSE.
+Authors: Johannes Hölzl, Mario Carneiro, Patrick Massot
+-/
+import Mathlib.Topology.Homeomorph.Defs
+import Mathlib.Topology.Maps.Basic
+
+/-!
+# Direct sums and products of topological spaces
```
PAST COMMENT (from reviewer):
```suggestion
# Disjoint unions and products of topological spaces
```
--- candidate 13 (sim=0.694, past_pr=#13170, file=Mathlib/Topology/Category/LightProfinite/IsLight.lean) ---
PAST HUNK:
```
@@ -34,6 +34,8 @@ universe u
open CategoryTheory Limits FintypeCat Opposite TopologicalSpace
+attribute [local instance] ConcreteCategory.instFunLike -- TODO remove this?
```
PAST COMMENT (from reviewer):
```suggestion
-- This was a global instance prior to #13170. We may experiment with removing it.
attribute [local instance] ConcreteCategory.instFunLike
```
--- candidate 14 (sim=0.694, past_pr=#13170, file=Mathlib/Topology/Category/TopCat/Limits/Products.lean) ---
PAST HUNK:
```
@@ -327,10 +331,10 @@ theorem binaryCofan_isColimit_iff {X Y : TopCat} (c : BinaryCofan X Y) :
(binaryCofanIsColimit X Y)).symm.openEmbedding.comp openEmbedding_inl,
(homeoOfIso <| h.coconePointUniqueUpToIso
(binaryCofanIsColimit X Y)).symm.openEmbedding.comp openEmbedding_inr, ?_⟩
- erw [Set.range_comp, ← eq_compl_iff_isCompl, coe_comp, coe_comp, Set.range_comp _ Sum.inr,
+ erw [Set.range_comp, ← eq_compl_iff_isCompl, Set.range_comp _ Sum.inr,
← Set.image_compl_eq (homeoOfIso <| h.coconePointUniqueUpToIso
(binaryCofanIsColimit X Y)).symm.bijective, Set.compl_range_inr, Set.image_comp]
- aesop
+ -- now `erw` after #13170
```
PAST COMMENT (from reviewer):
```suggestion
```
--- candidate 15 (sim=0.693, past_pr=#2110, file=Mathlib/Topology/Constructions.lean) ---
PAST HUNK:
```
@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
Authors: Johannes Hölzl, Mario Carneiro, Patrick Massot
! This file was ported from Lean 3 source module topology.constructions
-! leanprover-community/mathlib commit bcfa726826abd57587355b4b5b7e78ad6527b7e4
+! leanprover-community/mathlib commit dc6c365e751e34d100e80fe6e314c3c3e0fd2988
```
PAST COMMENT (from reviewer):
In future, always check the port status page for a forward-port; if there is another PR that changes the file before yours, then mark your PR as dependent on that one.
I intend to build a bot that pastes these links automatically
--- candidate 16 (sim=0.693, past_pr=#2110, file=Mathlib/Topology/Constructions.lean) ---
PAST HUNK:
```
@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
Authors: Johannes Hölzl, Mario Carneiro, Patrick Massot
! This file was ported from Lean 3 source module topology.constructions
-! leanprover-community/mathlib commit bcfa726826abd57587355b4b5b7e78ad6527b7e4
+! leanprover-community/mathlib commit dc6c365e751e34d100e80fe6e314c3c3e0fd2988
```
PAST COMMENT (from reviewer):
Namely, this incorrectly marks this file as up to date, but did not forward-port all the necessary changes
--- candidate 17 (sim=0.692, past_pr=#26446, file=Mathlib/Topology/Category/CompHaus/Basic.lean) ---
PAST HUNK:
```
@@ -170,17 +170,22 @@ def limitCone {J : Type v} [SmallCategory J] (F : J ⥤ CompHaus.{max v u}) : Li
def limitConeIsLimit {J : Type v} [SmallCategory J] (F : J ⥤ CompHaus.{max v u}) :
Limits.IsLimit.{v} (limitCone.{v,u} F) :=
letI FF : J ⥤ TopCat := F ⋙ compHausToTop
- { lift := fun S => (TopCat.limitConeIsLimit FF).lift (compHausToTop.mapCone S)
- fac := fun S => (TopCat.limitConeIsLimit FF).fac (compHausToTop.mapCone S)
- uniq := fun S => (TopCat.limitConeIsLimit FF).uniq (compHausToTop.mapCone S) }
+ { lift := fun S => InducedCategory.homMk
+ ((TopCat.limitConeIsLimit FF).lift (compHausToTop.mapCone S))
+ fac := fun S j => by aesop
```
PAST COMMENT (from reviewer):
```suggestion
```
--- candidate 18 (sim=0.691, past_pr=#11334, file=Mathlib/Topology/Instances/AddCircle.lean) ---
PAST HUNK:
```
@@ -11,6 +11,7 @@ import Mathlib.Algebra.Order.Floor
import Mathlib.Algebra.Order.ToIntervalMod
import Mathlib.Topology.Instances.Real
import Mathlib.Topology.Connected.PathConnected
+import Mathlib.Topology.IsLocalHomeomorph
```
PAST COMMENT (from reviewer):
can you run `#minimize_imports` on this file? I think there is some redundancy here
--- candidate 19 (sim=0.689, past_pr=#22278, file=Mathlib/CategoryTheory/Sums/Basic.lean) ---
PAST HUNK:
```
@@ -4,6 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
Authors: Kim Morrison, Robin Carlier
-/
import Mathlib.CategoryTheory.Equivalence
+import Mathlib.CategoryTheory.Products.Basic
```
PAST COMMENT (from reviewer):
The new code should probably go in a separate file `CategoryTheory.Sums.Products`.
--- candidate 20 (sim=0.689, past_pr=#26446, file=Mathlib/Topology/Category/CompHaus/Basic.lean) ---
PAST HUNK:
```
@@ -170,17 +170,22 @@ def limitCone {J : Type v} [SmallCategory J] (F : J ⥤ CompHaus.{max v u}) : Li
... [2 lines above hidden]
Limits.IsLimit.{v} (limitCone.{v,u} F) :=
letI FF : J ⥤ TopCat := F ⋙ compHausToTop
- { lift := fun S => (TopCat.limitConeIsLimit FF).lift (compHausToTop.mapCone S)
- fac := fun S => (TopCat.limitConeIsLimit FF).fac (compHausToTop.mapCone S)
- uniq := fun S => (TopCat.limitConeIsLimit FF).uniq (compHausToTop.mapCone S) }
+ { lift := fun S => InducedCategory.homMk
+ ((TopCat.limitConeIsLimit FF).lift (compHausToTop.mapCone S))
+ fac := fun S j => by aesop
+ uniq := fun S m hm => InducedCategory.hom_ext
+ ((TopCat.limitConeIsLimit FF).uniq (compHausToTop.mapCone S) _ (fun j ↦ by
+ dsimp
+ rw [← hm]
+ rfl )) }
```
PAST COMMENT (from reviewer):
```suggestion
simp [← hm]
rfl )) }
```
Decide which candidates' comments genuinely apply to the NEW hunk. If none, say so. Output JSON only.
[ASSISTANT]
----------------------------------------------------------------------------------------------------
{
"new_hunk_plausible_concerns": [
"imports-module",
"docstring"
],
"summary": "The new file only contains imports (including a duplicate), so prior feedback about minimizing and deduplicating imports applies; also consider adding a module docstring.",
"confidence": "high",
"strong_matches": [
{
"past_pr": 11334,
"past_file": "Mathlib/Topology/Instances/AddCircle.lean",
"past_concern_axis": "imports-module",
"past_comment_excerpt": "can you run `#minimize_imports` on this file? I think there is some redundancy here",
"applies_because": "This new file is just a list of imports, and one import appears twice; running #minimize_imports would remove the duplicate and any unnecessary imports.",
"suggested_adaptation": "Please run #minimize_imports and drop redundant imports (there is also a duplicate `TopCat.Limits.Basic` import).",
"why_might_not_apply": "Future additions to the file might require some of these imports.",
"supporting_past_prs": []
},
{
"past_pr": 2508,
"past_file": "Mathlib/Topology/Order/ScottTopology.lean",
"past_concern_axis": "imports-module",
"past_comment_excerpt": "Can you trim down the imports? Only a few are actually needed.",
"applies_because": "Given the file currently only imports many modules (with a duplicate), trimming to the minimal necessary set is appropriate.",
"suggested_adaptation": "Trim the import list to only what is needed for this file and remove the duplicated line.",
"why_might_not_apply": "Without seeing the upcoming contents, it's hard to know the exact minimal set.",
"supporting_past_prs": []
}
],
"weak_observations": [
{
"observation": "The same import `Mathlib.Topology.Category.TopCat.Limits.Basic` appears twice; remove the duplicate.",
"axis": "imports-module",
"supporting_past_prs": [
11334,
2508
]
},
{
"observation": "Consider adding a short module-level docstring (`/-! ... -/`) describing the purpose of `TopPair`.",
"axis": "docstring",
"supporting_past_prs": [
22827
]
}
]
}