Skip to content

Commit 5bc541b

Browse files
do not override judge model decision
1 parent 9d01865 commit 5bc541b

4 files changed

Lines changed: 13 additions & 5 deletions

File tree

dist/index.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -647,7 +647,9 @@ const DEFAULT_REVIEWER_MODELS = [
647647
];
648648
const DEFAULT_JUDGE_MODEL = "openai/gpt-oss-120b";
649649
function normalizeReviewDecision(decision, findingsCount) {
650-
if (findingsCount > 0) {
650+
// Only upgrade COMMENT to REQUEST_CHANGES if there are findings
651+
// Never override explicit judge decisions (APPROVE or REQUEST_CHANGES)
652+
if (decision === "COMMENT" && findingsCount > 0) {
651653
return "REQUEST_CHANGES";
652654
}
653655
return decision;
@@ -2389,7 +2391,9 @@ ${reasons}`;
23892391
});
23902392
}
23912393
normalizeReviewDecision(decision, findings) {
2392-
if (findings.length > 0) {
2394+
// Only upgrade COMMENT to REQUEST_CHANGES if there are findings
2395+
// Never override explicit judge decisions (APPROVE or REQUEST_CHANGES)
2396+
if (decision === "COMMENT" && findings.length > 0) {
23932397
return "REQUEST_CHANGES";
23942398
}
23952399
return decision;

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ function normalizeReviewDecision(
4747
decision: "APPROVE" | "REQUEST_CHANGES" | "COMMENT",
4848
findingsCount: number
4949
): "APPROVE" | "REQUEST_CHANGES" | "COMMENT" {
50-
if (findingsCount > 0) {
50+
// Only upgrade COMMENT to REQUEST_CHANGES if there are findings
51+
// Never override explicit judge decisions (APPROVE or REQUEST_CHANGES)
52+
if (decision === "COMMENT" && findingsCount > 0) {
5153
return "REQUEST_CHANGES";
5254
}
5355

src/review/review-orchestrator.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,9 @@ ${reasons}`;
397397
decision: ReviewDecision,
398398
findings: CodeFinding[]
399399
): ReviewDecision {
400-
if (findings.length > 0) {
400+
// Only upgrade COMMENT to REQUEST_CHANGES if there are findings
401+
// Never override explicit judge decisions (APPROVE or REQUEST_CHANGES)
402+
if (decision === "COMMENT" && findings.length > 0) {
401403
return "REQUEST_CHANGES";
402404
}
403405

0 commit comments

Comments
 (0)