Too-eager version/tag/release normalization

[nikolay]

aqua info

$ aqua info
{
  "version": "2.57.2",
  "os": "darwin",
  "arch": "arm64",
  "cwd": "/Users/(USER)/Code/[REDACTED]",
  "root_dir": "/Users/(USER)/.local/share/aquaproj-aqua",
  "env": {
    "AQUA_GHTKN_ENABLED": "true",
    "AQUA_PROGRESS_BAR": "true"
  },
  "config_files": [
    {
      "path": "/Users/(USER)/Code/[REDACTED]/aqua/aqua.yaml"
    }
  ]
}

Overview

Aqua strips off v, rendering eza-community/eza broken due to the non-existent tag/release. I am posting this here as it used to work and just recently broke, so, I think it's the aqua binary issue.

How to reproduce

aqua.yaml

checksum:
  enabled: true
  require_checksum: true
  supported_envs:
  - darwin
  - linux
registries:
- name: local
  type: local
  path: registry.yaml
- type: standard
  ref: v4.505.0 # renovate: depName=aquaproj/aqua-registry
import_dir: imports
packages:
- name: eza-community/eza@0.23.4

Other related code such as local Registry

ackages: []

Executed command and output

$ aqua upc --deep --prune
May  4 10:31:32.600 INF downloading an asset to calculate the checksum program=aqua version=2.57.2 env=darwin/arm64 package_name=eza-community/eza package_version=0.23.4 package_registry=standard checksum_env=linux/amd64 asset_name=eza_x86_64-unknown-linux-musl.tar.gz
May  4 10:31:33.417 ERR update checksums program=aqua version=2.57.2 env=darwin/arm64 package_name=eza-community/eza package_version=0.23.4 package_registry=standard asset_name=eza_x86_64-unknown-linux-musl.tar.gz error="download an asset: get the GitHub Release by Tag: GET https://api.github.com/repos/eza-community/eza/releases/tags/0.23.4: 404 Not Found []"
/Users/[REDACTED]/Code/[REDACTED]/aqua/aqua-checksums.json
May  4 10:31:33.518 ERR aqua failed program=aqua version=2.57.2 env=darwin/arm64 error="it failed to update some packages' checksums"

Expected behaviour

Aqua should use the v prefix, and the update should pass.

Actual behaviour

It returns the error above.

Note

I actually have to manually insert the missing v so that the package installs properly.

[suzuki-shunsuke]

- name: eza-community/eza@0.23.4

Please add v to the version.

- name: eza-community/eza@v0.23.4

aqua g adds v properly.

$ aqua -v
aqua version 2.57.2

$ aqua g eza-community/eza
- name: eza-community/eza@v0.23.4

I don't think this is an issue of aqua.

[nikolay]

@suzuki-shunsuke What removes the v, though, is the aqua update. After I run it, I need to add the v prefix back.

[suzuki-shunsuke]

I see. I could reproduce the issue.

$ aqua up eza
May  5 17:18:28.603 INF updating a package program=aqua version=2.57.2 env=darwin/arm64 old_version=v0.23.4 new_version=0.23.4 package_name=eza-community/eza

This is because the version is fetched from crates.io because the package type is cargo in macOS.

https://github.com/aquaproj/aqua-registry/blob/dcbf92824e2147b09fa4a328f69de05a1fda87b1/pkgs/eza-community/eza/registry.yaml#L55-L59

[suzuki-shunsuke]

A workaround is to use the package crates.io/eza instead.

https://github.com/aquaproj/aqua-registry/blob/main/pkgs/crates.io/eza/registry.yaml

[suzuki-shunsuke]

This package uses both github_release type (with v prefix) and cargo type (without v prefix), but their version formats are different.
Unfortunately, there is no way to normalize versions.

• Related issue: Support formatting package versions (e.g. trim prefix) #1341

[nikolay]

@suzuki-shunsuke I've been using the crates.io version, but it takes a long time to compile. But I swear it used to work for a while and suddenly broke.

[suzuki-shunsuke]

it takes a long time to compile

Yes. Usually it takes a long time to compile rust tools. This is a problem of Rust.
eza-community/eza doesn't provide pre-built binaries for macOS, so you need to compile them on macOS.
Seems like you use macOS, so it can't be helped.

https://github.com/eza-community/eza/releases/tag/v0.23.4

But I swear it used to work for a while and suddenly broke.

Does it fail to install crates.io/eza? Could you tell me how to reproduce the issue and the output?
I can install crates.io/eza using aqua v2.57.2 on my macOS (M3 Pro).

$ eza --help
May  5 17:57:05.086 INF Installing a crate program=aqua version=2.57.2 env=darwin/arm64 exe_name=eza package_name=crates.io/eza package_version=0.23.4 registry=standard
    Updating crates.io index
  Downloaded eza v0.23.4
  Downloaded 1 crate (214.2KiB) in 0.15s
...

If it fails to install crates.io/eza, could you try cargo install eza?
If it fails, it's not the problem of aqua.

[nikolay]

@suzuki-shunsuke I didn't know they didn't provide macOS binaries. Crates worked and still do, but I just wanted to speed it up. Anyway, it's also possible to add a feature to rewrite the version number in the overrides section.