Skip to content

security: verify_window_contents() stubbed out — no validation performed #20122

Description

@shunfeng8421

Summary

verify_window_contents() in consensus/src/consensus_observer/network/observer_message.rs:350-351 is a stubbed-out security check that always returns Ok(()):

/// Verifies the execution pool window contents and returns an error if the data is invalid
pub fn verify_window_contents(&self, _expected_window_size: u64) -> Result<(), Error> {
    Ok(()) // TODO: Implement this method!
}

Impact

Invalid or malformed execution pool window data from other validators passes through unchecked. The method comment explicitly says it should verify data and return errors for invalid data, but does neither.

Location

  • consensus/src/consensus_observer/network/observer_message.rs:350-351
  • PipelinedBlockV2::verify_window_contents()

Fix

Validate that window blocks count matches expected_window_size and that block data is well-formed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions