Remove pfb submodule; require pfb as an installed dependency

pfb now supports direct execution, so sourcing lib/pfb/pfb.sh is no
longer needed. Replace submodule bootstrapping in all scripts with a
`command -v pfb` guard that exits with a clear install message if pfb
is not on PATH. Remove .gitmodules and the lib/pfb submodule entry.

Closes #32

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: ali5ter

.gitmodules

@@ -23,8 +23,6 @@ publication-library/
 │       ├── pdfs/                 ← source PDFs (gitignored; may be a symlink to cloud storage)
 │       └── indexed/              ← converted output (gitignored)
 ├── findings/                     ← personal research outputs (gitignored)
-├── lib/
-│   └── pfb/                      ← pretty-feedback terminal output library (submodule)
 ├── LIBRARIAN.md                  ← AI orientation guide (read this first)
 ├── CATALOGUE.md                  ← master cross-collection index (local instance, generated)
 ├── COLLECTION.md.example         ← template for writing COLLECTION.md files

CLAUDE.md

@@ -3,18 +3,17 @@
 #
 # Reconstructs the complete library from a clean clone:
 #   1. Validates configuration (.env, LIBRARY_BASE)
-#   2. Initialises the lib/pfb submodule if needed
-#   3. Creates cloud-storage directories for each collection
-#   4. Runs init-symlinks.sh to restore local symlinks
-#   5. Downloads PDFs for each collection (skips if already present)
-#   6. Converts PDFs to searchable Markdown (skips if already done)
-#   7. Regenerates the cross-collection CATALOGUE.md
+#   2. Creates cloud-storage directories for each collection
+#   3. Runs init-symlinks.sh to restore local symlinks
+#   4. Downloads PDFs for each collection (skips if already present)
+#   5. Converts PDFs to searchable Markdown (skips if already done)
+#   6. Regenerates the cross-collection CATALOGUE.md
 #
 # Name:         bootstrap.sh
 # Description:  Full reconstruction pipeline for a publication-library instance
 # Author:       Alister Lewis-Bowen <alister@lewis-bowen.org>
 # Usage:        ./bootstrap.sh
-# Dependencies: bash 4+, python3, pymupdf, git, lib/pfb submodule
+# Dependencies: bash 4+, python3, pymupdf, git, pfb
 # Exit codes:   0 success, 1 error
 #
 # Configuration (via .env or environment):
@@ -36,16 +35,12 @@ if [[ -f "${SCRIPT_DIR}/.env" ]]; then
     source "${SCRIPT_DIR}/.env"
 fi
 
-# Initialise lib/pfb submodule if not already done
-if [[ ! -f "${SCRIPT_DIR}/lib/pfb/pfb.sh" ]]; then
-    echo "Initialising lib/pfb submodule..."
-    git submodule update --init lib/pfb
+# Require pfb for terminal output
+if ! command -v pfb &>/dev/null; then
+    echo "ERROR: pfb is required but not found. Install it from https://github.com/ali5ter/pfb" >&2
+    exit 1
 fi
 
-# Load pfb for terminal output
-# shellcheck source=lib/pfb/pfb.sh
-source "${SCRIPT_DIR}/lib/pfb/pfb.sh"
-
 # ---------------------------------------------------------------------------
 # Validate required configuration
 # ---------------------------------------------------------------------------

bootstrap.sh

@@ -20,15 +20,9 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 FINDINGS_DIR="${SCRIPT_DIR}/findings"
 CLOUD_TYPE="${1:-}"
 
-# Load pfb for terminal output
-PFB_SCRIPT="${SCRIPT_DIR}/lib/pfb/pfb.sh"
-if [[ -f "${PFB_SCRIPT}" ]]; then
-    # shellcheck source=lib/pfb/pfb.sh
-    source "${PFB_SCRIPT}"
-elif command -v pfb &>/dev/null; then
-    : # pfb already on PATH
-else
-    echo "ERROR: pfb not found. Run: git submodule update --init lib/pfb" >&2
+# Require pfb for terminal output
+if ! command -v pfb &>/dev/null; then
+    echo "ERROR: pfb is required but not found. Install it from https://github.com/ali5ter/pfb" >&2
     exit 1
 fi
 

init-findings.sh

@@ -9,7 +9,7 @@
 # Description:  Recreate cloud-storage symlinks for a publication-library instance
 # Author:       Alister Lewis-Bowen <alister@lewis-bowen.org>
 # Usage:        ./init-symlinks.sh
-# Dependencies: bash 4+, lib/pfb submodule (or pfb on PATH)
+# Dependencies: bash 4+, pfb
 # Exit codes:   0 success, 1 error
 #
 # Configuration (via .env or environment):
@@ -43,15 +43,9 @@ if [[ -f "${SCRIPT_DIR}/.env" ]]; then
     source "${SCRIPT_DIR}/.env"
 fi
 
-# Load pfb for terminal output
-PFB_SCRIPT="${SCRIPT_DIR}/lib/pfb/pfb.sh"
-if [[ -f "${PFB_SCRIPT}" ]]; then
-    # shellcheck source=lib/pfb/pfb.sh
-    source "${PFB_SCRIPT}"
-elif command -v pfb &>/dev/null; then
-    : # pfb already on PATH
-else
-    echo "ERROR: pfb not found. Run: git submodule update --init lib/pfb" >&2
+# Require pfb for terminal output
+if ! command -v pfb &>/dev/null; then
+    echo "ERROR: pfb is required but not found. Install it from https://github.com/ali5ter/pfb" >&2
     exit 1
 fi