Skip to content

Commit 2495d37

Browse files
author
unknown
committed
admin(typography): clean up h3 rules superseded by unified global heading
Follow-up to the previous commit that unified .admin-main h1/h2/h3 to the 28px page-title scale. Audit pass over the existing rules to remove duplicated work and per-page sizing overrides that now defeat the global intent. Trimmed redundant properties (kept the rule for its unique work): - sidebar-nav.css '.admin-main .content-header h3' — dropped color / font-size / font-weight / line-height. Kept margin:0 (wrapper handles spacing), padding:0, boxes.css background wipe, overflow ellipsis. - sidebar-nav.css second '.content-header h3, .head-products, ...' block — dropped h3 from the selector list, kept the legacy span selectors (.head-products / .head-sales-order / .head-customer) that still need explicit 28px since they're <span>s. - dark-theme.css '.content-header h3' — dropped font-size:18px / font-weight / letter-spacing / text-transform / margin / line-height. Kept color (defensive outside .admin-main), boxes.css background wipe, padding-left:0. Removed entirely (per-page h3 size overrides that contradicted the unified 28px scale or were pure redundancy): - body.adminhtml-permissions-user-(edit|new) .content-header h3 { font-size:20px } - body[class*='adminhtml-system_config'] .content-header h3 { font-size:18px } - body[class*='customoptions-options-edit'] .content-header h3 portion — split so only the h4 sub-label rule remains. - .dashboard .box-head h3 { color:var(--t1) } — single-property rule, color is now identical to what global emits. Left intentionally: - cache-index / process-list h3 — those h3s are deliberate small uppercase section labels (e.g. 'Additional Cache Management'), not page titles, so the per-page small override is the correct design role. - catalog-product-edit .side-col h3 — sidebar tab labels. - .admin-main .box-head h3 — panel section headers. - workflowguides .wfg-guide-header h2 — sets display:flex layout, not just sizing. - is-order-view / catalog-category side-col / generic h1-h6 { color:var(--t1) } — defensive coverage for headings outside .admin-main (modals, popups).
1 parent a962a26 commit 2495d37

2 files changed

Lines changed: 25 additions & 31 deletions

File tree

skin/adminhtml/default/default/dark-theme.css

Lines changed: 15 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -386,16 +386,15 @@ body .header-top {
386386
padding: 0 !important;
387387
}
388388
.content-header h3, .content-header h3.icon-head {
389+
/* color / font-size / font-weight / letter-spacing / text-transform
390+
/ margin now come from the unified global heading rule in
391+
sidebar-nav.css. Keep only the legacy-boxes.css icon-background
392+
wipe and the zero left-padding so this rule still earns its keep
393+
outside of .admin-main (modals, side panels, etc.). */
389394
color: var(--t1) !important;
390395
background: none !important;
391396
background-image: none !important;
392-
font-size: 18px !important;
393-
font-weight: 700 !important;
394-
letter-spacing: -0.1px !important;
395-
text-transform: none !important;
396397
padding-left: 0 !important;
397-
margin: 0 !important;
398-
line-height: 1.2 !important;
399398
}
400399
/* Page container */
401400
#page\:main-container { padding: 16px 10px 16px 8px !important; }
@@ -3086,7 +3085,8 @@ ul.tabs-horiz li a.active {
30863085
background-image: none !important;
30873086
border-color: var(--b1) !important;
30883087
}
3089-
.dashboard .box-head h3 { color: var(--t1) !important; }
3088+
/* `.dashboard .box-head h3` color rule removed — color now comes from the
3089+
unified global heading rule (also var(--t1)). */
30903090
.dashboard .col2-set, .dashboard .col2-set .col-1, .dashboard .col2-set .col-2 { background: var(--d1) !important; }
30913091
.dashboard .col-2 .box, .dashboard .col-2 .box .hor-scroll, .dashboard .col-2 .box .box-head, .dashboard .col-2 { background: var(--d3) !important; }
30923092
.dashboard .box .totals, .dashboard .box .totals table,
@@ -3690,12 +3690,9 @@ body.adminhtml-permissions-user-new #edit_form hr {
36903690
display: none !important;
36913691
}
36923692

3693-
/* Header row: title + button bar. Buttons get the "modal footer" treatment. */
3694-
body.adminhtml-permissions-user-edit .content-header h3,
3695-
body.adminhtml-permissions-user-new .content-header h3 {
3696-
font-size: 20px !important;
3697-
font-weight: 700 !important;
3698-
}
3693+
/* Header row: title + button bar. Buttons get the "modal footer" treatment.
3694+
(Per-page h3 size override removed — the unified global heading rule in
3695+
sidebar-nav.css now sets every h1/h2/h3 to 28px / 700 consistently.) */
36993696
body.adminhtml-permissions-user-edit .content-header button.back,
37003697
body.adminhtml-permissions-user-new .content-header button.back {
37013698
background: transparent !important;
@@ -3865,13 +3862,8 @@ body[class*="adminhtml-system_config"] .content-header {
38653862
margin: 0 0 4px !important;
38663863
}
38673864
body[class*="adminhtml-system_config"] .content-header > table { width: 100% !important; }
3868-
body[class*="adminhtml-system_config"] .content-header h3 {
3869-
color: var(--t1) !important;
3870-
font: 700 18px/1.2 inherit !important;
3871-
text-transform: none !important;
3872-
letter-spacing: -0.1px !important;
3873-
margin: 0 !important;
3874-
}
3865+
/* Per-page h3 size override removed — unified by the global rule in
3866+
sidebar-nav.css ('.admin-main h1, h2, h3' → 28px / 700). */
38753867

38763868
/* Section row — no card. Hairline between siblings. Kill ALL wrappers. */
38773869
body[class*="adminhtml-system_config"] #config_edit_form .entry-edit,
@@ -4924,8 +4916,9 @@ body[class*="customoptions-options-edit"] [id*="group"][class*="box"] {
49244916
color: var(--t2) !important;
49254917
}
49264918

4927-
/* Compact page header (Edit Template '...') */
4928-
body[class*="customoptions-options-edit"] .content-header h3,
4919+
/* Compact page header (Edit Template '...') — h3 now follows the global
4920+
28px rule; h4 keeps its compact 13px override here since it's used as
4921+
a sub-label on this page. */
49294922
body[class*="customoptions-options-edit"] .content-header h4 {
49304923
font-size: 18px !important;
49314924
font-weight: 700 !important;

skin/adminhtml/default/default/sidebar-nav.css

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -867,16 +867,17 @@ body.sidebar-collapsed .admin-main {
867867
.admin-main .content-header td[style*="float"] {
868868
float: none !important;
869869
}
870+
/* Color / font-size / font-weight / line-height now come from the
871+
unified global heading rule at the bottom of this file. Keep only
872+
the properties this rule was uniquely contributing: zero out the
873+
margin/padding so the .content-header wrapper handles spacing, wipe
874+
the legacy boxes.css icon backgrounds, and let long titles ellipsis. */
870875
.admin-main .content-header h3,
871876
.admin-main .content-header h3.icon-head {
872-
color: var(--t1) !important;
873-
font-size: 28px !important;
874-
font-weight: 700 !important;
875877
margin: 0 !important;
876878
padding: 0 !important;
877879
background: none !important;
878880
background-image: none !important;
879-
line-height: 1.2 !important;
880881
white-space: nowrap;
881882
overflow: hidden;
882883
text-overflow: ellipsis;
@@ -1259,11 +1260,11 @@ body table.data tr.selected td a {
12591260
color: #64748b !important;
12601261
}
12611262

1262-
/* Page title — unified canonical size (no glow). 28px / 700.
1263-
See admin-dashboard.css → "Global page-title type ramp" for the
1264-
single source of truth that also normalises every MMD panel
1265-
`<h1 class="*-title">`. */
1266-
.admin-main .content-header h3,
1263+
/* Page title spans inside .content-header — the legacy boxes.css
1264+
ships .head-products / .head-sales-order / .head-customer as <span>
1265+
classes used as icon-headers. Headings are normalised by the unified
1266+
global heading rule at the bottom of this file; these span selectors
1267+
still need the title scale since they aren't h1/h2/h3 elements. */
12671268
.admin-main .content-header .head-products,
12681269
.admin-main .content-header .head-sales-order,
12691270
.admin-main .content-header .head-customer {

0 commit comments

Comments
 (0)