Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Commit 9b0222c

Browse files
authored
💄 feat: ensure setting description doesn't wrap under toggle button per design review (#1285)
1 parent c907a7b commit 9b0222c

1 file changed

Lines changed: 33 additions & 26 deletions

File tree

client/flutter/lib/pages/settings_page.dart

Lines changed: 33 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -204,37 +204,44 @@ class _SettingsPageState extends State<SettingsPage>
204204
child: Padding(
205205
padding: const EdgeInsets.symmetric(
206206
horizontal: 24,
207-
vertical: 16,
207+
vertical: 20,
208208
),
209-
child: Column(
209+
child: Row(
210+
crossAxisAlignment: CrossAxisAlignment.start,
210211
children: <Widget>[
211-
Row(
212-
children: <Widget>[
213-
Expanded(
214-
child: ThemedText(header,
215-
variant: TypographyVariant.h3,
216-
textAlign: TextAlign.start,
217-
style: TextStyle(
218-
color: Constants.neutral1Color,
219-
)),
220-
),
221-
Semantics(
222-
excludeSemantics: true,
223-
child: Switch.adaptive(
224-
value: isToggled,
225-
onChanged: onToggle,
226-
activeColor: Constants.primaryColor,
212+
Expanded(
213+
child: Column(
214+
crossAxisAlignment: CrossAxisAlignment.stretch,
215+
children: <Widget>[
216+
Padding(
217+
padding: const EdgeInsets.only(top: 10.0, bottom: 8.0),
218+
child: ThemedText(header,
219+
variant: TypographyVariant.h3,
220+
style: TextStyle(
221+
color: Constants.neutral1Color,
222+
)),
227223
),
228-
)
229-
],
224+
Padding(
225+
padding: const EdgeInsets.only(right: 8.0),
226+
child: ThemedText(
227+
info,
228+
variant: TypographyVariant.body,
229+
style: TextStyle(
230+
color: Constants.neutral2Color,
231+
),
232+
),
233+
)
234+
],
235+
),
230236
),
231-
ThemedText(
232-
info,
233-
variant: TypographyVariant.body,
234-
style: TextStyle(
235-
color: Constants.neutral2Color,
237+
Semantics(
238+
excludeSemantics: true,
239+
child: Switch.adaptive(
240+
value: isToggled,
241+
onChanged: onToggle,
242+
activeColor: Constants.primaryColor,
236243
),
237-
)
244+
),
238245
],
239246
),
240247
),

0 commit comments

Comments
 (0)