Skip to content

Commit 0f5bb8b

Browse files
chore: fix tests
1 parent de4bbee commit 0f5bb8b

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

tests/test_binning_piecewise.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,11 +196,11 @@ def test_bounds_transform():
196196

197197
x_transform_woe = optb.transform(x, metric="woe")
198198
assert x_transform_woe[:4] == approx(
199-
[3.99180564, 4.28245092, 4.17407503, -3.2565373], rel=1e-6)
199+
[3.99180564, 4.28245092, 4.17407503, -3.2565373], rel=1e-5)
200200

201201
x_transform_event_rate = optb.transform(x, metric="event_rate")
202202
assert x_transform_event_rate[:4] == approx(
203-
[0.03015878, 0.02272502, 0.02526056, 0.97763604], rel=1e-6)
203+
[0.03015878, 0.02272502, 0.02526056, 0.97763604], rel=1e-5)
204204

205205

206206
def test_bounds_fit_transform():
@@ -210,11 +210,11 @@ def test_bounds_fit_transform():
210210
x, y, lb=0.001, ub=0.999, metric="woe")
211211

212212
assert x_transform_woe[:4] == approx(
213-
[3.9918056, 4.2824509, 4.17407503, -3.25653732], rel=1e-6)
213+
[3.9918056, 4.2824509, 4.17407503, -3.25653732], rel=1e-5)
214214
x_transform_event_rate = optb.fit_transform(
215215
x, y, lb=0.001, ub=0.999, metric="event_rate")
216216
assert x_transform_event_rate[:4] == approx(
217-
[0.03015878, 0.02272502, 0.02526056, 0.97763604], rel=1e-6)
217+
[0.03015878, 0.02272502, 0.02526056, 0.97763604], rel=1e-5)
218218

219219

220220
def test_solvers():

tests/test_continuous_binning_piecewise.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def test_fit_transform():
4949

5050
def test_special_codes():
5151
variable = "INDUS"
52-
x = df[variable].values
52+
x = df[variable].values.copy()
5353

5454
x[:50] = -9
5555
x[50:100] = -8

tests/test_scorecard.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -470,10 +470,11 @@ def test_missing_metrics():
470470
np.array([0]*90 + [1]*10)
471471
)
472472
),
473-
'var': [np.nan] * 100 + ['A'] * 100}
473+
'var': pd.array([np.nan] * 100 + ['A'] * 100, dtype=object)}
474474
)
475475

476-
binning_process = BinningProcess(['var'])
476+
binning_process = BinningProcess(['var'],
477+
categorical_variables=['var'])
477478
scaling_method_params = {'min': 0, 'max': 100}
478479

479480
scorecard = Scorecard(

0 commit comments

Comments
 (0)