Merge pull request #155 from QWED-AI/fix/schema-uniqueitems-fail-closed

fix: fail closed on uniqueItems validation errors

Author: rahuldass19

src/qwed_new/core/schema_verifier.py

@@ -504,9 +504,18 @@ def _validate_array(
                         ))
                         break
                     seen.add(item_key)
-            except (TypeError, ValueError):
-                pass  # Can't check uniqueness for unhashable items
-        
+            except (TypeError, ValueError) as exc:
+                issues.append(SchemaIssue(
+                    path=path,
+                    issue_type="uniqueness_validation_error",
+                    expected="provably unique items",
+                    actual="uniqueness check could not be completed",
+                    message=(
+                        "uniqueItems could not be verified deterministically: "
+                        f"{exc}"
+                    )
+                ))
+
         # items (single schema for all items)
         if "items" in schema and isinstance(schema["items"], dict):
             for i, item in enumerate(data):

tests/test_schema_verifier.py

@@ -242,8 +242,18 @@ def test_unique_items_invalid(self, verifier):
         """Array with duplicates fails."""
         schema = {"type": "array", "uniqueItems": True}
         result = verifier.verify([1, 2, 2, 3], schema)
+        assert not result["is_valid"]
+
+    def test_unique_items_uncheckable_fails_closed(self, verifier):
+        """If uniqueness cannot be proven, validation must fail closed."""
+        schema = {"type": "array", "uniqueItems": True}
+        result = verifier.verify([{"bad": {1, 2}}, {"bad": {3, 4}}], schema)
+
         assert result["is_valid"] == False
-    
+        assert result["status"] == "INVALID"
+        assert result["issues"][0]["type"] == "uniqueness_validation_error"
+        assert "uniqueItems could not be verified deterministically" in result["issues"][0]["message"]
+
     def test_items_schema(self, verifier):
         """Array items validated against item schema."""
         schema = {