Merge pull request #206 from PatrikBak/patrik/cli-await-before-registrar-dispose

Await commands before disposing the CLI DI registrar

Author: PatrikBak

backend/src/MathComps.Shared.Cli/Commands/CliApp.cs

@@ -76,13 +76,15 @@ public CliApp ConfigureServices(Action<IServiceCollection, IConfiguration> confi
     /// <param name="args">Command-line arguments forwarded from <c>Program.cs</c>.</param>
     /// <param name="configure">Registers the tool's commands on the Spectre configurator.</param>
     /// <returns>The process exit code: 0 on success, 1 on an unhandled exception.</returns>
-    public Task<int> RunAsync(string[] args, Action<IConfigurator>? configure = null)
+    public async Task<int> RunAsync(string[] args, Action<IConfigurator>? configure = null)
     {
-        // Build the DI registrar through the shared bootstrap.
+        // Build the DI registrar through the shared bootstrap. Awaiting before the using disposes it keeps the
+        // service provider (and its singletons, e.g. the HttpClient meter factory) alive until the async command
+        // actually finishes.
         using var registrar = BuildRegistrar();
 
         // Run a command app with no compile-time default command.
-        return CliRunner.RunAsync(new CommandApp(registrar), args, configure);
+        return await CliRunner.RunAsync(new CommandApp(registrar), args, configure);
     }
 
     /// <summary>
@@ -93,14 +95,16 @@ public Task<int> RunAsync(string[] args, Action<IConfigurator>? configure = null
     /// <param name="args">Command-line arguments forwarded from <c>Program.cs</c>.</param>
     /// <param name="configure">Optionally registers additional commands on the Spectre configurator.</param>
     /// <returns>The process exit code: 0 on success, 1 on an unhandled exception.</returns>
-    public Task<int> RunAsync<TDefaultCommand>(string[] args, Action<IConfigurator>? configure = null)
+    public async Task<int> RunAsync<TDefaultCommand>(string[] args, Action<IConfigurator>? configure = null)
         where TDefaultCommand : class, ICommand
     {
-        // Build the DI registrar through the shared bootstrap.
+        // Build the DI registrar through the shared bootstrap. Awaiting before the using disposes it keeps the
+        // service provider (and its singletons, e.g. the HttpClient meter factory) alive until the async command
+        // actually finishes.
         using var registrar = BuildRegistrar();
 
         // Run a command app whose default command is the supplied type.
-        return CliRunner.RunAsync(new CommandApp<TDefaultCommand>(registrar), args, configure);
+        return await CliRunner.RunAsync(new CommandApp<TDefaultCommand>(registrar), args, configure);
     }
 
     /// <summary>