Skip to content

Commit af3d793

Browse files
JarbasAlclaude
andauthored
fix: use list.remove() instead of list.pop() in whitelist_skill (#394)
list.pop() takes an integer index; passing a skill ID string raises TypeError at runtime. list.remove() takes the value to remove. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent ec9ff79 commit af3d793

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

ovos_workshop/permissions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def whitelist_skill(skill, config=None):
2424
skills_config = config.get("skills", {})
2525
blacklisted_skills = skills_config.get("blacklisted_skills", [])
2626
if skill in blacklisted_skills:
27-
blacklisted_skills.pop(skill)
27+
blacklisted_skills.remove(skill)
2828
conf = {
2929
"skills": {
3030
"blacklisted_skills": blacklisted_skills

0 commit comments

Comments
 (0)