Prefer PINE_OUTPUT_DIR or /mnt/pinescripts as default output across scripts

Author: OdynBrouwer

batch_download.py

@@ -12,16 +12,31 @@
 import argparse
 import asyncio
 import sys
+import os
 from pathlib import Path
 
 # Import from the enhanced downloader (which is now fixed)
 from tv_downloader_enhanced import EnhancedTVScraper
 
 
-async def batch_download(urls: list[str], output_dir: str = "./pinescript_downloads", 
+async def batch_download(urls: list[str], output_dir: str | None = None, 
                         delay: float = 2.0, max_pages: int = 10, visible: bool = False, debug_pages: bool = False):
     """Download from multiple URLs sequentially.
 
+    visible: show browser window when downloading each page
+    debug_pages: enable per-page debugging output
+    """
+    # Resolve output_dir default if None
+    if not output_dir:
+        env_output = os.environ.get('PINE_OUTPUT_DIR')
+        if env_output:
+            output_dir = env_output
+        elif os.path.exists('/mnt/pinescripts'):
+            output_dir = '/mnt/pinescripts'
+        else:
+            output_dir = './pinescript_downloads'
+    """Download from multiple URLs sequentially.
+
     visible: show browser window when downloading each page
     debug_pages: enable per-page debugging output
     """
@@ -105,10 +120,19 @@ async def main():
         help='URLs to download from'
     )
 
+    # Default output: prefer env PINE_OUTPUT_DIR, else use /mnt/pinescripts if present, else local folder
+    env_output = os.environ.get('PINE_OUTPUT_DIR')
+    if env_output:
+        default_output = env_output
+    elif os.path.exists('/mnt/pinescripts'):
+        default_output = '/mnt/pinescripts'
+    else:
+        default_output = './pinescript_downloads'
+
     parser.add_argument(
         '--output', '-o',
-        default='./pinescript_downloads',
-        help='Output directory'
+        default=default_output,
+        help='Output directory (defaults to PINE_OUTPUT_DIR or /mnt/pinescripts when available)'
     )
 
     parser.add_argument(

tv_downloader_enhanced.py

@@ -51,8 +51,19 @@ def extract_script_id(url: str) -> str:
 
 
 class EnhancedTVScraper:
-    def __init__(self, output_dir: str = "./pinescript_downloads", headless: bool = True):
-        self.output_dir = Path(output_dir)
+    def __init__(self, output_dir: str | None = None, headless: bool = True):
+        # Resolve default output: prefer env PINE_OUTPUT_DIR, then /mnt/pinescripts, otherwise ./pinescript_downloads
+        if output_dir:
+            resolved = output_dir
+        else:
+            env_output = os.environ.get('PINE_OUTPUT_DIR')
+            if env_output:
+                resolved = env_output
+            elif os.path.exists('/mnt/pinescripts'):
+                resolved = '/mnt/pinescripts'
+            else:
+                resolved = './pinescript_downloads'
+        self.output_dir = Path(resolved)
         self.headless = headless
         self.browser = None
         self.context = None

tv_downloader_fixed.py

@@ -39,8 +39,18 @@ def extract_script_id(url: str) -> str:
 
 
 class TVPineScriptDownloader:
-    def __init__(self, output_dir: str = "./pinescript_downloads", headless: bool = True):
-        self.output_dir = Path(output_dir)
+    def __init__(self, output_dir: str | None = None, headless: bool = True):
+        if output_dir:
+            resolved = output_dir
+        else:
+            env_output = os.environ.get('PINE_OUTPUT_DIR')
+            if env_output:
+                resolved = env_output
+            elif os.path.exists('/mnt/pinescripts'):
+                resolved = '/mnt/pinescripts'
+            else:
+                resolved = './pinescript_downloads'
+        self.output_dir = Path(resolved)
         self.headless = headless
         self.browser = None
         self.context = None
@@ -386,7 +396,16 @@ def _print_summary(self, category: str):
 async def main():
     parser = argparse.ArgumentParser(description='Download Pine Scripts from TradingView')
     parser.add_argument('--url', '-u', required=True, help='TradingView scripts URL')
-    parser.add_argument('--output', '-o', default='./pinescript_downloads', help='Output directory')
+    # Default output: prefer env PINE_OUTPUT_DIR, else /mnt/pinescripts if present, else local folder
+    env_output = os.environ.get('PINE_OUTPUT_DIR')
+    if env_output:
+        default_output = env_output
+    elif os.path.exists('/mnt/pinescripts'):
+        default_output = '/mnt/pinescripts'
+    else:
+        default_output = './pinescript_downloads'
+
+    parser.add_argument('--output', '-o', default=default_output, help='Output directory')
     parser.add_argument('--max-pages', '-p', type=int, default=30, help='Max show-more clicks')
     parser.add_argument('--delay', '-d', type=float, default=2.0, help='Delay between downloads')
     parser.add_argument('--visible', action='store_true', help='Show browser window')

tv_pinescript_downloader.py

@@ -55,8 +55,18 @@ def extract_script_name(url: str) -> str:
 
 
 class TradingViewScraper:
-    def __init__(self, output_dir: str = "./pinescript_downloads", headless: bool = True):
-        self.output_dir = Path(output_dir)
+    def __init__(self, output_dir: str | None = None, headless: bool = True):
+        if output_dir:
+            resolved = output_dir
+        else:
+            env_output = os.environ.get('PINE_OUTPUT_DIR')
+            if env_output:
+                resolved = env_output
+            elif os.path.exists('/mnt/pinescripts'):
+                resolved = '/mnt/pinescripts'
+            else:
+                resolved = './pinescript_downloads'
+        self.output_dir = Path(resolved)
         self.headless = headless
         self.browser = None
         self.context = None
@@ -425,8 +435,17 @@ async def main():
 
     parser.add_argument(
         '--output', '-o',
-        default='./pinescript_downloads',
-        help='Output directory for downloaded scripts (default: ./pinescript_downloads)'
+        # Default output: prefer env PINE_OUTPUT_DIR, else /mnt/pinescripts if present, else local folder
+        env_output = os.environ.get('PINE_OUTPUT_DIR')
+        if env_output:
+            default_output = env_output
+        elif os.path.exists('/mnt/pinescripts'):
+            default_output = '/mnt/pinescripts'
+        else:
+            default_output = './pinescript_downloads'
+        
+        default=default_output,
+        help='Output directory for downloaded scripts (default: PINE_OUTPUT_DIR or /mnt/pinescripts if available)'
     )
 
     parser.add_argument(