Add SOFTSSharp model#1516
Conversation
|
Thanks for the contribution. Please, refer to these PRs to see how to contribute a new model to the repository: In its current state, we cannot accept this PR. Thanks! |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@marcopeix Thanks for the guidance. I updated the PR following the patterns in #1445 and #1469. The PR now adds:
Local checks passed. |
|
Hi @hljubic. Looking good! A couple of things:
Thanks a lot! |
|
@marcopeix Sorry for late response. I added the requested PNG figure to the SOFTSSharp documentation and ran a paper-like ETTh1 96/96 reproducibility check for SOFTSSharp. For ETTh1, I used h=96, input_size=96, the standard ETTh1 train/validation/test split, five random seeds [1, 2, 3, 4, 5], and the same main SOFTSSharp configuration across all runs.
Average across five seeds:
The results are consistent with the paper-level results, with slightly lower average errors in this implementation. |
|
@hljubic sorry, some work was merged and the branch has a conflict in the auto version. Should be a simple fix, let me know if you need help! Otherwise, looks good! |
|
@marcopeix done, it should be okay now. |
There was a problem hiding this comment.
@hljubic
The linter check didn't pass. Make sure to install and run pre-commit hooks. Refer to our CONTRIBUTING.md.
|
@marcopeix sorry, I added a new commit and double-checked it. I hope it’s okay now. |
This PR adds SOFTSSharp, an extension of SOFTS that introduces stochastic variable-position encoding inside the STAD aggregation-redistribution component.
SOFTSSharp is intended as an incremental improvement over SOFTS while preserving linear computational complexity.
Reference implementation and ongoing research:
https://github.com/hljubic/SOFTSsharp
Changes: