Skip to content

migrate tests from nbs to pytest#1353

Merged
deven367 merged 69 commits into
mainfrom
rm-nbdev
Aug 15, 2025
Merged

migrate tests from nbs to pytest#1353
deven367 merged 69 commits into
mainfrom
rm-nbdev

Conversation

@deven367

@deven367 deven367 commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator

This PR is a WIP to remove nbdev from neuralforecast.

cc @goodwanghan @marcopeix

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant

CLAassistant commented Jul 1, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@deven367 deven367 marked this pull request as draft July 1, 2025 13:24
@deven367

deven367 commented Jul 8, 2025

Copy link
Copy Markdown
Collaborator Author

tests for AutoModels have been moved with their respective models
cc @marcopeix

Comment thread tests/test_core.py
@marcopeix

Copy link
Copy Markdown
Contributor

For the memory issues on MacOS, despite setting the MPS fallback variable, maybe we can try running the tests on a single thread? Don't know if they are running in parallel or not, but we could try setting n_workers=1 see if it solves the issue.

@deven367

Copy link
Copy Markdown
Collaborator Author

@marcopeix I just checked, pytest is single threaded by default

@marcopeix marcopeix self-requested a review August 15, 2025 19:52
@deven367 deven367 merged commit ad31fd1 into main Aug 15, 2025
31 checks passed
@deven367 deven367 deleted the rm-nbdev branch August 15, 2025 20:02
elephaint pushed a commit that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants