Skip to content

Data Regularization being done on input chunks in SklNeurNetEstimator #33

Description

@eacharles

Bug report

We don't really use SklNeurNetEstimator, but it has these lines:

        color_data = make_color_data(
            data, self.config.bands, self.config.ref_band, self.config.nondetect_val
        )
        input_data = regularize_data(color_data)
        zmode = np.round(self.model.predict(input_data), 3)

Which result in getting different numbers for subsets of data that when input the full data, because the regularize_data is only being called on the subset. Instead we should save the regularization from the training run and use that.

Before submitting
Please check the following:

  • I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
  • I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a descriprion of what I expected instead.
  • If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions