Updating JSON escaping.

JusticeRage · JusticeRage · commit 2eefb5f7d22b · 2026-01-30T00:17:32.000+01:00
diff --git a/include/manacommons/escape.h b/include/manacommons/escape.h
@@ -128,7 +128,7 @@ struct escape_impl<escaped_string_json<OutputIterator>>
 				case '\r': generated += "\\r"; break;
 				case '\t': generated += "\\t"; break;
 				default:
-					if (c < 0x20)
+					if (c < 0x20 || c >= 0x7f)
 					{
 						generated += "\\u00";
 						generated += hex_digits[(c >> 4) & 0x0F];
diff --git a/test/escape.cpp b/test/escape.cpp
@@ -92,6 +92,8 @@ BOOST_AUTO_TEST_CASE(test_string_escape_json)
 	check_string_escaping_json("\b", "\\b");
 	check_string_escaping_json("\f", "\\f");
 	check_string_escaping_json("\t", "\\t");
+	check_string_escaping_json(std::string("\x7f", 1), "\u007F");
+	check_string_escaping_json(std::string("\xe9", 1), "\u00E9");
 	check_string_escaping_json("\v", "\\u000B");
 	check_string_escaping_json("\r\n", "\\r\\n");
 }

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ struct escape_impl<escaped_string_json<OutputIterator>>`
`128`	`128`	`case '\r': generated += "\\r"; break;`
`129`	`129`	`case '\t': generated += "\\t"; break;`
`130`	`130`	`default:`
`131`		`- if (c < 0x20)`
	`131`	`+ if (c < 0x20 \|\| c >= 0x7f)`
`132`	`132`	`{`
`133`	`133`	`generated += "\\u00";`
`134`	`134`	`generated += hex_digits[(c >> 4) & 0x0F];`
Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,8 @@ BOOST_AUTO_TEST_CASE(test_string_escape_json)`
`92`	`92`	`check_string_escaping_json("\b", "\\b");`
`93`	`93`	`check_string_escaping_json("\f", "\\f");`
`94`	`94`	`check_string_escaping_json("\t", "\\t");`
	`95`	`+ check_string_escaping_json(std::string("\x7f", 1), "\u007F");`
	`96`	`+ check_string_escaping_json(std::string("\xe9", 1), "\u00E9");`
`95`	`97`	`check_string_escaping_json("\v", "\\u000B");`
`96`	`98`	`check_string_escaping_json("\r\n", "\\r\\n");`
`97`	`99`	`}`