Merge pull request #49 from Juliusolsson05/fix/drop-embed-gate

fix: drop embed detection gate and trust canonical videoId

Author: Juliusolsson05

src/app/api/v1/perspectives/live-status/route.ts

@@ -8,54 +8,16 @@ const IS_LIVE_RE = /"isLive"\s*:\s*true/;
 
 type CacheEntry = {
   isLive: boolean;
-  playableInEmbed: boolean;
   videoId: string | null;
   checkedAt: number;
 };
 
 const cache = new Map<string, CacheEntry>();
 
-async function isEmbeddableVideo(videoId: string) {
-  const oembedUrl = `https://www.youtube.com/oembed?url=https://www.youtube.com/watch?v=${videoId}&format=json`;
-
-  try {
-    const res = await fetch(oembedUrl, {
-      headers: { 'User-Agent': 'Mozilla/5.0' },
-      signal: AbortSignal.timeout(8000),
-    });
-
-    return res.ok;
-  } catch {
-    return false;
-  }
-}
-
-async function parseLivePlayback(html: string) {
-  const canonicalVideoId = html.match(CANONICAL_VIDEO_RE)?.[1] ?? null;
-
-  if (!canonicalVideoId) {
-    return {
-      playableInEmbed: false,
-      videoId: null,
-    };
-  }
-
-  const playableInEmbed = await isEmbeddableVideo(canonicalVideoId);
-
-  return {
-    playableInEmbed,
-    videoId: playableInEmbed ? canonicalVideoId : null,
-  };
-}
-
-async function checkLiveStatus(handle: string): Promise<{ isLive: boolean; playableInEmbed: boolean; videoId: string | null }> {
+async function checkLiveStatus(handle: string): Promise<{ isLive: boolean; videoId: string | null }> {
   const cached = cache.get(handle);
   if (cached && Date.now() - cached.checkedAt < CACHE_TTL * 1000) {
-    return {
-      isLive: cached.isLive,
-      playableInEmbed: cached.playableInEmbed,
-      videoId: cached.videoId,
-    };
+    return { isLive: cached.isLive, videoId: cached.videoId };
   }
 
   try {
@@ -65,17 +27,13 @@ async function checkLiveStatus(handle: string): Promise<{ isLive: boolean; playa
     });
     const html = await res.text();
     const isLive = IS_LIVE_RE.test(html);
-    const playback = isLive
-      ? await parseLivePlayback(html)
-      : { playableInEmbed: false, videoId: null };
-    const playableInEmbed = playback.playableInEmbed;
-    const videoId = playback.videoId;
+    const videoId = isLive ? (html.match(CANONICAL_VIDEO_RE)?.[1] ?? null) : null;
 
-    cache.set(handle, { isLive, playableInEmbed, videoId, checkedAt: Date.now() });
-    return { isLive, playableInEmbed, videoId };
+    cache.set(handle, { isLive, videoId, checkedAt: Date.now() });
+    return { isLive, videoId };
   } catch {
-    cache.set(handle, { isLive: false, playableInEmbed: false, videoId: null, checkedAt: Date.now() });
-    return { isLive: false, playableInEmbed: false, videoId: null };
+    cache.set(handle, { isLive: false, videoId: null, checkedAt: Date.now() });
+    return { isLive: false, videoId: null };
   }
 }
 
@@ -85,10 +43,10 @@ export async function GET(req: NextRequest) {
     return err('INVALID_PARAMS', 'handle query param required (e.g. ?handle=@SkyNews)');
   }
 
-  const { isLive, playableInEmbed, videoId } = await checkLiveStatus(handle);
+  const { isLive, videoId } = await checkLiveStatus(handle);
 
   return ok(
-    { handle, isLive, playableInEmbed, videoId, ttl: CACHE_TTL },
+    { handle, isLive, playableInEmbed: isLive && Boolean(videoId), videoId, ttl: CACHE_TTL },
     {
       headers: {
         'Cache-Control': `public, s-maxage=${CACHE_TTL}, stale-while-revalidate=${CACHE_TTL}`,