Merge branch 'refactor/nav-community-routes'

Author: Guillaume

.ai/thought_log.md

@@ -1,3 +1,19 @@
+## [2026-06-28] Cohérence navigation — Phase 1 : rename /palmares → /community (+ Face-à-face) — COMPLÉTÉ + vérifié
+
+**Tâche** : refonte cohérence nav (plan 3 phases, `.ai/plans` zany-growing-marble). Phase 1 = aligner l'URL sur le libellé « Communauté ».
+
+**Phase 1** :
+- Routes `routes/.../palmares/{index,relations,prestige}.tsx` + `compare.tsx` → `community/{index,relations,prestige,compare}.tsx` (URLs `/community/*`).
+- Anciennes URLs préservées par routes redirect (`beforeLoad → throw redirect`).
+- Callsites : `isCommunityPath` (matche /community + legacy), navL1Sections (defaultPath + onglets), NavL2 (COMMUNITY_*), pageTitle, classifyFeedback, deep-links Explorer/Career → /community/compare, PLAYER_PRIMARY_NAV_ITEMS (label Palmarès → Communauté). Fix en passant : notif `season_pass_level` → /career/season-pass (était /palmares, stale).
+- Backend inchangé (API /pages/palmares/* découplée). routeTree.gen.ts régénéré (vite build).
+
+**Vérif** : build OK, typecheck, vitest 2048 pass (seul échec = `HomeSpartanIdentityBanner`, PRÉ-EXISTANT — commit Spartan d'un autre agent, hors de mon changeset), eslint 0 err, lint colors/fields/cross-feature + knip sous plafonds.
+
+**Suite (plan)** : Phase 2 re-nesting (/synthesis→/stats/synthesis, /citations+commendations→/career/) ; Phase 3 onglets `?tab=` → segments de route (Timeseries, Match View). Convention : sous-vue = route, query-param = filtres, store = toggles.
+
+---
+
 ## [2026-06-28] Personnalisateur Spartan (emblèmes/nameplates Halo 5) — modale home + recolor live — COMPLÉTÉ + vérifié
 
 **Tâche** : feature Halo-5-only. Clic sur la bannière d'identité de l'accueil → modale (sans navigation) pour parcourir les emblèmes, choisir des couleurs (rouge/bleu présélectionnés), voir le nameplate + l'emblème recolorisés EN DIRECT côte à côte (non collés), puis Enregistrer/Annuler. Plan : `.ai/PLAN_H5_SPARTAN_CUSTOMIZER.md`.

apps/web/src/components/shell/NavL1.test.tsx

@@ -58,7 +58,7 @@ describe('NavL1', () => {
   })
 
   it('marque Communauté actif sur les sous-routes du hub', () => {
-    mockPathname = '/players/test-player/palmares/relations'
+    mockPathname = '/players/test-player/community/relations'
 
     renderWithProviders(<NavL1 />)
 

apps/web/src/components/shell/NavL2.tsx

@@ -21,13 +21,13 @@ import { useCapability } from '@/lib/capabilities/capabilities'
 import { isCommunityPath } from './shellNavigation'
 
 // Onglet « Classements » de la section Communauté (gaté sur world.leaderboard).
-const COMMUNITY_LEADERBOARD_PATH = '/players/$playerSlug/palmares'
+const COMMUNITY_LEADERBOARD_PATH = '/players/$playerSlug/community'
 
 // ─── Sous-onglets de la section Carrière ──────────────────────────────────────
 
 const CAREER_TABS = [
   { label: 'Progression', path: '/players/$playerSlug/career' },
-  { label: 'Citations', path: '/players/$playerSlug/citations' },
+  { label: 'Citations', path: '/players/$playerSlug/career/citations' },
   { label: 'Pass saisonnier', path: '/players/$playerSlug/career/season-pass' },
 ] as const
 
@@ -43,15 +43,15 @@ const CAREER_TABS_H5 = [
   { label: 'Progression', path: '/players/$playerSlug/career' },
   // Halo 5 : commendations natives, libellé FR « Citations » (terme officiel Halo
   // FR, cohérent avec Infinite et l'onglet L1).
-  { label: 'Citations', path: '/players/$playerSlug/commendations' },
+  { label: 'Citations', path: '/players/$playerSlug/career/commendations' },
 ] as const
 
 // Communauté : aligné sur le dropdown L1 (NavL1 section 'community'). Face-à-face
 // pointe vers /compare (hors /palmares), d'où des chemins absolus par onglet.
 const COMMUNITY_TABS = [
-  { label: 'Classements', path: '/players/$playerSlug/palmares' },
-  { label: 'Relations', path: '/players/$playerSlug/palmares/relations' },
-  { label: 'Face-à-face', path: '/players/$playerSlug/compare' },
+  { label: 'Classements', path: '/players/$playerSlug/community' },
+  { label: 'Relations', path: '/players/$playerSlug/community/relations' },
+  { label: 'Face-à-face', path: '/players/$playerSlug/community/compare' },
 ] as const
 
 // ─── Helpers ──────────────────────────────────────────────────────────────────
@@ -63,6 +63,8 @@ const PERSONAL_STATS_RE = /\/players\/[^/]+\/stats\/(summary|maps-modes|distribu
 
 function detectSection(pathname: string): ActiveSection {
   if (PERSONAL_STATS_RE.test(pathname)) return null
+  // Synthèse gère sa propre barre de filtres (PeriodePill/SaisonPill) → pas de NavL2.
+  if (/\/players\/[^/]+\/stats\/synthesis/.test(pathname)) return null
   if (/\/players\/[^/]+\/stats\//.test(pathname)) return 'stats'
   if (/\/players\/[^/]+\/squad/.test(pathname)) return 'squad'
   if (/\/players\/[^/]+\/(career|citations|commendations)/.test(pathname)) return 'career'

apps/web/src/components/shell/navL1Sections.tsx

@@ -84,7 +84,7 @@ export const L1_SECTIONS: L1Section[] = [
     defaultPath: '/players/$playerSlug/stats/timeseries',
     matchPathname: (p) => /\/players\/[^/]+\/(stats\/|synthesis)/.test(p),
     tabs: [
-      { key: 'synthesis', label: 'Synthèse', path: '/players/$playerSlug/synthesis' },
+      { key: 'synthesis', label: 'Synthèse', path: '/players/$playerSlug/stats/synthesis' },
       { key: 'timeseries', label: 'Séries temporelles', path: '/players/$playerSlug/stats/timeseries' },
       { key: 'sessions', label: 'Sessions', path: '/players/$playerSlug/stats/sessions' },
     ],
@@ -107,7 +107,7 @@ export const L1_SECTIONS: L1Section[] = [
     matchPathname: (p) => /\/players\/[^/]+\/(career|citations|profile)/.test(p),
     tabs: [
       { key: 'progression', label: 'Progression', path: '/players/$playerSlug/career' },
-      { key: 'citations', label: 'Citations', path: '/players/$playerSlug/citations' },
+      { key: 'citations', label: 'Citations', path: '/players/$playerSlug/career/citations' },
       {
         key: 'season-pass',
         label: 'Pass saisonnier',
@@ -135,19 +135,19 @@ export const L1_SECTIONS: L1Section[] = [
   {
     key: 'community',
     label: 'Communauté',
-    defaultPath: '/players/$playerSlug/palmares',
+    defaultPath: '/players/$playerSlug/community',
     matchPathname: isCommunityPath,
     // Section transverse non gatée (Relations / Face-à-face dérivent des matchs) ;
     // seul l'onglet « Classements » dépend de `world.leaderboard`.
     tabs: [
       {
         key: 'leaderboard',
         label: 'Classements',
-        path: '/players/$playerSlug/palmares',
+        path: '/players/$playerSlug/community',
         capability: 'world.leaderboard',
       },
-      { key: 'relations', label: 'Relations', path: '/players/$playerSlug/palmares/relations' },
-      { key: 'compare', label: 'Face-à-face', path: '/players/$playerSlug/compare' },
+      { key: 'relations', label: 'Relations', path: '/players/$playerSlug/community/relations' },
+      { key: 'compare', label: 'Face-à-face', path: '/players/$playerSlug/community/compare' },
     ],
   },
   {

apps/web/src/components/shell/shellNavigation.test.ts

@@ -29,10 +29,10 @@ describe('buildPlayerDestination', () => {
     )
   })
 
-  it('place Palmarès avant Carrière dans le parcours principal', () => {
+  it('place Communauté avant Carrière dans le parcours principal', () => {
     const labels = PLAYER_PRIMARY_NAV_ITEMS.map((item) => item.label)
 
-    expect(labels.indexOf('Palmarès')).toBeGreaterThanOrEqual(0)
-    expect(labels.indexOf('Palmarès')).toBeLessThan(labels.indexOf('Carrière'))
+    expect(labels.indexOf('Communauté')).toBeGreaterThanOrEqual(0)
+    expect(labels.indexOf('Communauté')).toBeLessThan(labels.indexOf('Carrière'))
   })
 })

apps/web/src/components/shell/shellNavigation.ts

@@ -18,8 +18,8 @@ export const PLAYER_PRIMARY_NAV_ITEMS: ShellNavItem[] = [
     description: 'Briefing, signaux chauds et accès prioritaires.',
   },
   {
-    to: '/players/$playerSlug/palmares',
-    label: 'Palmarès',
+    to: '/players/$playerSlug/community',
+    label: 'Communauté',
     eyebrow: 'Prestige',
     description: 'Classements, relations et face-à-face joueur à joueur.',
   },
@@ -57,7 +57,7 @@ export const PLAYER_SECONDARY_NAV_ITEMS: ShellNavItem[] = [
     description: 'Approfondir, filtrer et descendre dans le détail.',
   },
   {
-    to: '/players/$playerSlug/synthesis',
+    to: '/players/$playerSlug/stats/synthesis',
     label: 'Synthèse',
     eyebrow: 'Recap',
     description: 'Vue consolidée et transversale.',
@@ -78,11 +78,14 @@ export const GLOBAL_SHELL_LINKS: ShellUtilityLink[] = [
  * sous-onglets) pour garder les deux navs synchronisées.
  */
 export function isCommunityPath(pathname: string): boolean {
-  const palmares =
-    /\/players\/[^/]+\/palmares(?:\/|$)/.test(pathname) &&
-    !/\/palmares\/season-pass/.test(pathname)
-  const compare = /\/players\/[^/]+\/compare/.test(pathname)
-  return palmares || compare
+  const community = /\/players\/[^/]+\/community(?:\/|$)/.test(pathname)
+  // Legacy : ancien /palmares (hors season-pass passé sous Carrière) + ancien /compare,
+  // encore surlignés Communauté le temps que les redirections vers /community s'appliquent.
+  const legacy =
+    (/\/players\/[^/]+\/palmares(?:\/|$)/.test(pathname) &&
+      !/\/palmares\/season-pass/.test(pathname)) ||
+    /\/players\/[^/]+\/compare(?:\/|$)/.test(pathname)
+  return community || legacy
 }
 
 export function buildPlayerDestination(

apps/web/src/features/career/CareerPage.tsx

@@ -77,7 +77,7 @@ export function CareerPage() {
           <Button
             size="sm"
             variant="outline"
-            onClick={() => void navigate({ to: '/players/$playerSlug/compare', params: { playerSlug } })}
+            onClick={() => void navigate({ to: '/players/$playerSlug/community/compare', params: { playerSlug } })}
           >
             {t('career.actions.compare')}
           </Button>

apps/web/src/features/compare/ComparePage.tsx

@@ -287,7 +287,7 @@ function MirrorHeader({
 export function ComparePage() {
   const { playerSlug } = useParams({ strict: false }) as { playerSlug: string }
   const navigate = useNavigate()
-  const search = useSearch({ from: '/players/$playerSlug/compare' }) as {
+  const search = useSearch({ from: '/players/$playerSlug/community/compare' }) as {
     target?: string
     target2?: string
     from?: 'explorer'
@@ -323,7 +323,7 @@ export function ComparePage() {
 
   function handleComboChange(values: string[]) {
     void navigate({
-      to: '/players/$playerSlug/compare',
+      to: '/players/$playerSlug/community/compare',
       params: { playerSlug },
       search: {
         target: values[0] ?? undefined,

apps/web/src/features/explorer/ExplorerPage.tsx

@@ -184,7 +184,7 @@ export function ExplorerPage() {
 
   function openHeadToHead(gamertag: string) {
     void navigate({
-      to: '/players/$playerSlug/compare',
+      to: '/players/$playerSlug/community/compare',
       params: { playerSlug },
       search: { target: gamertag, from: 'explorer' },
     })

apps/web/src/features/feedback-drawer/classifyFeedback.test.ts

@@ -126,6 +126,8 @@ describe('matchArea — toutes les routes', () => {
     ['/players/Foo/palmares/prestige', 'palmares'],
     ['/players/Foo/palmares/relations', 'palmares'],
     ['/players/Foo/palmares/season-pass', 'palmares'],
+    ['/players/Foo/community', 'palmares'],
+    ['/players/Foo/community/relations', 'palmares'],
     ['/players/Foo/home', 'player_home'],
     ['/players/Foo/media', 'media'],
     ['/players/Foo/career', 'career'],