Skip to content

Commit bf9c9b2

Browse files
committed
sort out defaults and parameters for GNIRS XD determineDistortion test
1 parent 9781627 commit bf9c9b2

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

geminidr/gnirs/parameters_gnirs_crossdispersed.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from geminidr.core import parameters_crossdispersed
55
from geminidr.core import parameters_standardize
66
from geminidr.core.parameters_standardize import addIllumMaskToDQConfig
7+
from . import parameters_gnirs_spect
78
from gempy.library import config
89

910

@@ -17,6 +18,12 @@ def setDefaults(self):
1718
self.add_illum_mask = True
1819

1920

21+
class determineDistortionConfig(parameters_gnirs_spect.determineDistortionConfig):
22+
def setDefaults(self):
23+
self.spatial_order = 2
24+
self.min_line_length = 0.5 # because some orders go off the edge
25+
26+
2027
class determineSlitEdgesConfig(parameters_spect.determineSlitEdgesConfig):
2128
# GNIRS XD has narrow slits with more curvature than the longslit flats
2229
# the default values were calibrated to, so adjust some values.

geminidr/gnirs/tests/crossdispersed/test_determine_distortion.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"max_shift": 0.05,
2525
"min_snr": 5.,
2626
"nsum": 10,
27+
"spatial_order": 2,
2728
"spectral_order": 3,
2829
"min_line_length": 0.5,
2930
"debug_reject_bad": False

0 commit comments

Comments
 (0)