expose min_snr in adjustWavelengthZeroPoint. It was failing in some higher GNIRS XD order because the sky lines are a bit weak. The error message said to adjust the min_snr but it was hardcoded and the user had no way to adjust it. Now it is a parameter to the primitive and it solves the problem.

Author: KathleenLabrie

geminidr/core/parameters_spect.py

@@ -41,6 +41,7 @@ class adjustWavelengthZeroPointConfig(config.Config):
                                 min=1, optional=True)
     shift = config.RangeField("Shift to apply in pixels (None: determine automatically)",
                               float, 0, min=-2048, max=2048, optional=True)
+    min_snr = config.RangeField("Minimum SNR for peak detection", float, 10., min=1.)
     verbose = config.Field("Print extra information", bool, False,
                            optional=True)
     debug_max_shift = config.RangeField("Maximum shift to allow (in pixels)",

geminidr/core/primitives_spect.py

@@ -136,6 +136,7 @@ def _add_shift_model_to_wcs(shift, ext):
         sfx = params["suffix"]
         center = params["center"]
         shift = params["shift"]
+        min_snr = params["min_snr"]
         max_shift = params["debug_max_shift"]
         verbose = params["verbose"]
 
@@ -181,7 +182,7 @@ def _add_shift_model_to_wcs(shift, ext):
                         "center": center,
                         "nsum": 10,
                         "fwidth": None,
-                        "min_snr": 10,
+                        "min_snr": min_snr,
                         "min_sep": 2,
                         "weighting": "local",
                         "nbright": 0,