tidy of parameters and determineDistortion() code after debugging

Author: chris-simpson

geminidr/core/parameters_spect.py

@@ -140,7 +140,7 @@ class determineDistortionConfig(config.Config):
     min_snr = config.RangeField("Minimum SNR for peak detection", float, 5., min=3.)
     fwidth = config.RangeField("Feature width in pixels if reidentifying",
                                float, None, min=1., optional=True)
-    nsum = config.RangeField("Number of lines to sum", int, 10, min=1)
+    nsum = config.RangeField("Number of lines to sum", int, 10, min=5)
     step = config.RangeField("Step in rows/columns for tracing", int, 10, min=1)
     max_shift = config.RangeField("Maximum shift per pixel in line position",
                                   float, 0.05, min=0.001, max=0.1)

geminidr/core/primitives_spect.py

@@ -1509,10 +1509,6 @@ def determineDistortion(self, adinputs=None, **params):
                             viewer=self.viewer if debug else None,
                             min_line_length=0.1))
 
-                print("TRACES")
-                for trace in traces:
-                    print(trace.input_coordinates())
-
                 # List of traced peak positions
                 in_coords = np.array([coord for trace in traces for
                                       coord in trace.input_coordinates()]).T
@@ -1523,16 +1519,6 @@ def determineDistortion(self, adinputs=None, **params):
                                 f"{ad.filename}:{ext.id}")
                     continue
 
-                # If there's a "rectified" frame, we want to use the pixel
-                # coordinates in *that* frame as input so that the pixels
-                # -> rectified -> distortion_corrected transform works
-                # correctly.
-                try:
-                    t = ext.wcs.get_transform(ext.wcs.input_frame, 'rectified')
-                except CoordinateFrameError:
-                    pass
-                else:
-                    in_coords = np.array(t(*in_coords))
                 # List of "reference" positions (i.e., the coordinate
                 # perpendicular to the line remains constant at its initial value
                 ref_coords = np.array([coord for trace in traces for

geminidr/gnirs/parameters_gnirs_crossdispersed.py

@@ -25,6 +25,7 @@ class determineDistortionConfig(parameters_spect.determineDistortionConfig):
                                int, None, min=0, optional=True)
     def setDefaults(self):
         self.min_snr = 10
+        self.spatial_order = 2
         self.debug_reject_bad = False