increase GNIRS XD max_shift to 0.5 and remove hardcoded limit for max shift (regardless of distance between points in tracing direction)

Author: chris-simpson

geminidr/gnirs/parameters_gnirs_crossdispersed.py

@@ -43,7 +43,7 @@ class determineSlitEdgesConfig(parameters_spect.determineSlitEdgesConfig):
     def setDefaults(self):
         self.min_snr = 0.5
         self.debug_max_missed = 4
-        self.debug_max_shift = 0.4
+        self.debug_max_shift = 0.5
         self.debug_step = 10
         self.debug_nsum = 10
         del self.edge1

gempy/library/tracing.py

@@ -753,16 +753,14 @@ def _profile_for_centering(data, var, rwidth):
                                                   for s in all_slices[these_steps]])
                         shift_tol = max_shift * abs(effective_ypos - trace.last_point[0])
                         predicted_peak = trace.predict_location(effective_ypos, order=1)
-                        peak_tol = 5
 
                         peaks, peak_values = pinpoint_peaks(
                             data[j], peaks=[predicted_peak], mask=mask[j],
                             halfwidth=halfwidth)
 
                         if (not peaks or min_peak_value is not None and
                                 peak_values[0] < min_peak_value or
-                                abs(peaks[0] - trace.last_point[1]) > shift_tol or
-                                abs(peaks[0] - predicted_peak) > peak_tol):
+                                abs(peaks[0] - trace.last_point[1]) > shift_tol):
                             continue
 
                         # A valid peak has been found