change makeBPM to use electrons for the dark limits as after an ADUToElectrons, the original gain is no longer accessible. The code was always using 1 for F2 and NIRI.

Author: KathleenLabrie

geminidr/core/parameters_nearIR.py

@@ -20,8 +20,8 @@ class addDQConfig(parameters_standardize.addDQConfig, addLatencyToDQConfig):
 
 class makeBPMConfig(config.Config):
     override_thresh = config.ChoiceField("Apply user-specified thresholds, overriding any default calculation?", bool, { True : 'Must be True where no default algorithm is implemented' }, default=True, optional=False)
-    dark_lo_thresh = config.Field("Low rejection threshold for dark (ADU)", float, None, optional=True)
-    dark_hi_thresh = config.Field("High rejection threshold for dark (ADU)", float, None, optional=True)
+    dark_lo_thresh = config.Field("Low rejection threshold for dark (electrons)", float, None, optional=True)
+    dark_hi_thresh = config.Field("High rejection threshold for dark (electrons)", float, None, optional=True)
     flat_lo_thresh = config.RangeField("Low rejection threshold for normalized flat", float, None, max=1.0, optional=True)
     flat_hi_thresh = config.RangeField("High rejection threshold for normalized flat", float, None, min=1.0, optional=True)
     keep_unilluminated = config.Field("Keep unilluminated pixels flags?", bool, False)

geminidr/core/primitives_nearIR.py

@@ -95,7 +95,7 @@ def makeBPM(self, adinputs=None, **params):
         Parameters
         ----------
         dark_lo_thresh, dark_hi_thresh: float, optional
-            Range of data values (always in ADUs) outside which pixels in the
+            Range of data values (always in electrons) outside which pixels in the
             input dark are considered bad (eg. -20 and 100, but these defaults
             vary by instrument). A limit of None is not applied and all pixels
             are considered good at that end of the range.
@@ -147,21 +147,22 @@ def makeBPM(self, adinputs=None, **params):
             log.stdinfo(msg.format(flat_lo, flat_hi))
             flat_mask = np.ma.masked_outside(flat_ext.data, flat_lo, flat_hi)
 
-            msg = "BPM Dark Mask Lower < > Upper Limit: {} < > {} ADU\n" \
-                  "                                    ({} < > {})"
             bunit = dark_ext.hdr.get('BUNIT', 'ADU').upper()
-            if bunit in ('ELECTRON', 'ELECTRONS'):
-                conv = dark_ext.gain()
-            elif bunit == 'ADU':
-                conv = 1
-            else:
+            if bunit not in ('ELECTRON', 'ELECTRONS', 'ADU'):
                 raise ValueError("Input units for dark should be ADU or "
                                  "ELECTRON, not {}".format(bunit))
-            log.stdinfo(msg.format(dark_lo, dark_hi,
-                                   conv*dark_lo, conv*dark_hi))
-            # create the mask -- darks (hot pixels)
+
+            msg = "BPM Dark Mask Lower < > Upper Limit: {} < > {} electrons\n" #\
+                  #"                                    ({} < > {})"
+            if bunit == 'ADU':
+                msg += "                                    ({:.2f} < > {:.2f}) ADU"
+                log.stdinfo(msg.format(dark_lo, dark_hi,
+                                   dark_lo/dark_ext.gain(), dark_hi/dark_ext.gain()))
+            else:
+                log.stdinfo(msg.format(dark_lo, dark_hi))
             dark_mask = np.ma.masked_outside(dark_ext.data,
-                                             conv*dark_lo, conv*dark_hi)
+                                             dark_lo / dark_ext.gain(),
+                                             dark_hi / dark_ext.gain())
 
             # combine masks and write to bpm file
             data_mask = np.ma.mask_or(np.ma.getmaskarray(dark_mask),

geminidr/f2/parameters_f2_image.py

@@ -18,6 +18,6 @@ def setDefaults(self):
 class makeBPMConfig(parameters_nearIR.makeBPMConfig):
     def setDefaults(self):
         self.dark_lo_thresh = -150.
-        self.dark_hi_thresh = 650.
+        self.dark_hi_thresh = 3050.
         self.flat_lo_thresh = 0.68
         self.flat_hi_thresh = 1.28

geminidr/niri/parameters_niri.py

@@ -23,6 +23,6 @@ def setDefaults(self):
 class makeBPMConfig(parameters_nearIR.makeBPMConfig):
     def setDefaults(self):
         self.dark_lo_thresh = -20.
-        self.dark_hi_thresh = 100.
+        self.dark_hi_thresh = 1300.
         self.flat_lo_thresh = 0.8
         self.flat_hi_thresh = 1.25