ViewFiltersLegend - multiple errors

[Wurschdhaud]

When running the script, the following issues appear:

Traceback (most recent call last):
File "C:\Users\XXX\AppData\Roaming\pyRevit\Extensions\EF-Tools.extension\EF_Tools.tab\Views.panel\Column2.stack\ViewFilters.pulldown\ViewFiltersLegend.pushbutton\script.py", line 523, in button_run
my_filter = ef_Filter(filter)
File "C:\Users\XXX\AppData\Roaming\pyRevit\Extensions\EF-Tools.extension\EF_Tools.tab\Views.panel\Column2.stack\ViewFilters.pulldown\ViewFiltersLegend.pushbutton\script.py", line 246, in init
self.rules = self.get_rules()
File "C:\Users\XXX\AppData\Roaming\pyRevit\Extensions\EF-Tools.extension\EF_Tools.tab\Views.panel\Column2.stack\ViewFilters.pulldown\ViewFiltersLegend.pushbutton\script.py", line 262, in get_rules
filter_rules = filter_filters.GetFilters()
AttributeError: 'ElementParameterFilter' object has no attribute 'GetFilters'

[Wurschdhaud]

I might have found a hint. Depending on whether the filter has been created in the UI or via a script, different unwrapping is necessary. Like so (different code, but similar principle):

# Get the internal ElementFilter from the ParameterFilterElement
element_filter = filter_element.GetElementFilter()
# Unwrap LogicalAndFilter or LogicalOrFilter if needed
if isinstance(element_filter, (DB.LogicalAndFilter, DB.LogicalOrFilter)):
    sub_filters = element_filter.GetFilters()
    if len(sub_filters) != 1:
        logger.warning("Filter has sub-filters. Only single sub-filter supported.")
        return
    element_filter = sub_filters[0]