refactor: simplify filtered hook handlers

Agent-Logs-Url: https://github.com/ElMassimo/iles/sessions/2f29b5ee-5bf6-4265-aed8-abd9fd19681f

Co-authored-by: ElMassimo <1158253+ElMassimo@users.noreply.github.com>

Author: Copilot

packages/iles/src/node/plugin/documents.ts

@@ -35,17 +35,14 @@ export default function documentsPlugin (config: AppConfig): Plugin {
     resolveId: {
       filter: { id: docsVirtualIdFilter },
       handler (id) {
-        if (id.startsWith(DOCS_VIRTUAL_ID))
-          return id
+        return id
       },
     },
     // Extract frontmatter for each file in the matching pattern, and create a
     // module where the default export is an array with each matching document.
     load: {
       filter: { id: docsVirtualIdFilter },
-      async handler (id, options) {
-        if (!id.startsWith(DOCS_VIRTUAL_ID)) return
-
+      async handler (id, _options) {
         const { query: { pattern: rawPath } } = parseId(id)
 
         // Extract pattern from the virtual module path, and resolve any alias.
@@ -121,7 +118,7 @@ export default function documentsPlugin (config: AppConfig): Plugin {
       filter: { id: fileCanUseDocuments },
       async handler (code, id) {
         // Replace each usage of useDocuments with an import of a virtual module.
-        if (fileCanUseDocuments.test(id) && !definitionRegex.test(code)) {
+        if (!definitionRegex.test(code)) {
           const paths: [string, string][] = []
           code = code.replace(usageRegex, (_, path) => {
             path = path.trim().slice(1, -1)

packages/iles/src/node/plugin/plugin.ts

@@ -136,8 +136,8 @@ export default function IslandsPlugins (appConfig: AppConfig): PluginOption[] {
       },
       transform: {
         filter: { id: APP_COMPONENT_PATH },
-        handler (code, id) {
-          if (id === APP_COMPONENT_PATH && !isBuild && appConfig.debug)
+        handler (code, _id) {
+          if (!isBuild && appConfig.debug)
             return code.replace('const DebugPanel = () => null', () => `import DebugPanel from '${DEBUG_COMPONENT_PATH}'`)
         },
       },

packages/images/src/images.ts

@@ -48,11 +48,9 @@ export default function IlesImagePresets (presets: ImagePresets, options?: Optio
           name: '@islands/images:inject-mdx-component',
           transform: {
             filter: { id: /\/composables\/mdxComponents\.js/ },
-            handler (code, id) {
-              if (id.includes('/composables/mdxComponents.js')) {
-                code = code.replace('inject(mdxComponentsKey)', '{ img: _Picture, ...inject(mdxComponentsKey) }')
-                return `import _Picture from '${PICTURE_COMPONENT_PATH}'\n${code}`
-              }
+            handler (code, _id) {
+              code = code.replace('inject(mdxComponentsKey)', '{ img: _Picture, ...inject(mdxComponentsKey) }')
+              return `import _Picture from '${PICTURE_COMPONENT_PATH}'\n${code}`
             },
           },
         },

packages/mdx/src/mdx-vite-plugins.ts

@@ -1,5 +1,3 @@
-import { extname } from 'path'
-
 import type { Plugin, TransformResult } from 'vite'
 import type { createFormatAwareProcessors } from '@mdx-js/mdx/internal-create-format-aware-processors'
 import hash from 'hash-sum'
@@ -13,10 +11,6 @@ export default function IlesMdx (options: MarkdownOptions = {}): Plugin[] {
   let markdownProcessor: ReturnType<typeof createFormatAwareProcessors>
   let isDevelopment: boolean
 
-  function shouldTransform (path: string) {
-    return markdownProcessor.extnames.includes(extname(path))
-  }
-
   async function createMdxProcessor (sourcemap: string | boolean) {
     const { createFormatAwareProcessors } = await import('@mdx-js/mdx/internal-create-format-aware-processors')
     markdownProcessor = createFormatAwareProcessors({
@@ -42,8 +36,6 @@ export default function IlesMdx (options: MarkdownOptions = {}): Plugin[] {
       transform: {
         filter: { id: markdownIdFilter },
         async handler (value, path) {
-          if (!shouldTransform(path)) return
-
           const compiled = await markdownProcessor.process({ value, path })
           return { code: String(compiled.value), map: compiled.map } as TransformResult
         },
@@ -55,8 +47,6 @@ export default function IlesMdx (options: MarkdownOptions = {}): Plugin[] {
       transform: {
         filter: { id: markdownIdFilter },
         async handler (code, path) {
-          if (!shouldTransform(path)) return
-
           return code.replace('export default function MDXContent', () => `
 import { defineComponent as $defineComponent } from 'iles/jsx-runtime'
 
@@ -75,8 +65,6 @@ function MDXContent`)
       transform: {
         filter: { id: markdownIdFilter },
         handler (code: string, path: string) {
-          if (!shouldTransform(path)) return
-
           const hmrId = hash(`${path.split('?', 2)[0]}default`)
 
           return `${code}

packages/pages/src/pages.ts

@@ -68,23 +68,20 @@ export default function IlesPages (): any {
       },
       resolveId: {
         filter: { id: moduleIdRegex },
-        async handler (id) {
-          if (moduleIdRegex.test(id))
-            return MODULE_ID
+        async handler (_id) {
+          return MODULE_ID
         },
       },
       load: {
         filter: { id: moduleIdRegex },
-        async handler (id) {
-          if (moduleIdRegex.test(id))
-            return generatedRoutes ||= await api.generateRoutesModule()
+        async handler (_id) {
+          return generatedRoutes ||= await api.generateRoutesModule()
         },
       },
       transform: {
         filter: { id: /vue&type=page/ },
-        async handler (_code, id) {
-          if (id.includes('vue&type=page'))
-            return 'export default {};'
+        async handler (_code, _id) {
+          return 'export default {};'
         },
       },
     }