fix: pass powershell build arguments safely

Avoid Invoke-Expression and manual quoting so Windows wheel scripts can create venvs in absolute paths without corrupting drive-qualified paths.

Author: DrHepa

native-wheels/scripts/build-diff-gaussian.ps1

@@ -25,19 +25,25 @@ function Invoke-Python {
         [string]$WorkingDirectory
     )
 
-    $command = "$Python $($Arguments -join ' ')"
-    Write-Host "[native-wheels] $command"
+    $pythonParts = $Python -split ' '
+    $pythonExe = $pythonParts[0]
+    $pythonArgs = @()
+    if ($pythonParts.Length -gt 1) {
+        $pythonArgs = $pythonParts[1..($pythonParts.Length - 1)]
+    }
+    $allArgs = @($pythonArgs) + @($Arguments)
+    Write-Host "[native-wheels] $pythonExe $($allArgs -join ' ')"
     if ($WorkingDirectory) {
         Push-Location $WorkingDirectory
         try {
-            Invoke-Expression $command
+            & $pythonExe @allArgs
         }
         finally {
             Pop-Location
         }
         return
     }
-    Invoke-Expression $command
+    & $pythonExe @allArgs
 }
 
 function Ensure-Directory {
@@ -69,7 +75,7 @@ $env:CUDACXX = (Join-Path $CudaRoot 'bin\nvcc.exe')
 $env:TORCH_CUDA_ARCH_LIST = $TorchCudaArchList
 $env:DISTUTILS_USE_SDK = '1'
 
-Invoke-Python -Arguments @('-m', 'venv', '"' + $venvDir + '"')
+Invoke-Python -Arguments @('-m', 'venv', $venvDir)
 $venvPython = Join-Path $venvDir 'Scripts\python.exe'
 
 & $venvPython -m pip install --upgrade pip setuptools wheel ninja

native-wheels/scripts/build-nvdiffrast.ps1

@@ -24,19 +24,25 @@ function Invoke-Python {
         [string]$WorkingDirectory
     )
 
-    $command = "$Python $($Arguments -join ' ')"
-    Write-Host "[native-wheels] $command"
+    $pythonParts = $Python -split ' '
+    $pythonExe = $pythonParts[0]
+    $pythonArgs = @()
+    if ($pythonParts.Length -gt 1) {
+        $pythonArgs = $pythonParts[1..($pythonParts.Length - 1)]
+    }
+    $allArgs = @($pythonArgs) + @($Arguments)
+    Write-Host "[native-wheels] $pythonExe $($allArgs -join ' ')"
     if ($WorkingDirectory) {
         Push-Location $WorkingDirectory
         try {
-            Invoke-Expression $command
+            & $pythonExe @allArgs
         }
         finally {
             Pop-Location
         }
         return
     }
-    Invoke-Expression $command
+    & $pythonExe @allArgs
 }
 
 function Ensure-Directory {
@@ -67,7 +73,7 @@ $env:CUDACXX = (Join-Path $CudaRoot 'bin\nvcc.exe')
 $env:TORCH_CUDA_ARCH_LIST = $TorchCudaArchList
 $env:DISTUTILS_USE_SDK = '1'
 
-Invoke-Python -Arguments @('-m', 'venv', '"' + $venvDir + '"')
+Invoke-Python -Arguments @('-m', 'venv', $venvDir)
 $venvPython = Join-Path $venvDir 'Scripts\python.exe'
 
 & $venvPython -m pip install --upgrade pip setuptools wheel ninja

native-wheels/scripts/smoke-test.ps1

@@ -18,19 +18,25 @@ function Invoke-Python {
         [string]$WorkingDirectory
     )
 
-    $command = "$Python $($Arguments -join ' ')"
-    Write-Host "[native-wheels] $command"
+    $pythonParts = $Python -split ' '
+    $pythonExe = $pythonParts[0]
+    $pythonArgs = @()
+    if ($pythonParts.Length -gt 1) {
+        $pythonArgs = $pythonParts[1..($pythonParts.Length - 1)]
+    }
+    $allArgs = @($pythonArgs) + @($Arguments)
+    Write-Host "[native-wheels] $pythonExe $($allArgs -join ' ')"
     if ($WorkingDirectory) {
         Push-Location $WorkingDirectory
         try {
-            Invoke-Expression $command
+            & $pythonExe @allArgs
         }
         finally {
             Pop-Location
         }
         return
     }
-    Invoke-Expression $command
+    & $pythonExe @allArgs
 }
 
 $resolvedWheelDir = [System.IO.Path]::GetFullPath($WheelDir)
@@ -51,7 +57,7 @@ if (-not $diffGaussianWheel) {
 $tempRoot = Join-Path ([System.IO.Path]::GetTempPath()) ('modly-trellis-text-native-smoke-' + [System.Guid]::NewGuid().ToString('N'))
 $venvDir = Join-Path $tempRoot 'venv'
 
-Invoke-Python -Arguments @('-m', 'venv', '"' + $venvDir + '"')
+Invoke-Python -Arguments @('-m', 'venv', $venvDir)
 $venvPython = Join-Path $venvDir 'Scripts\python.exe'
 
 try {

validate_text_only_setup.py

@@ -154,18 +154,21 @@ def validate_native_wheels_tooling() -> None:
     build_nvdiffrast = (ROOT / "native-wheels" / "scripts" / "build-nvdiffrast.ps1").read_text(encoding="utf-8")
     require("Set-StrictMode -Version Latest" in build_nvdiffrast, "build-nvdiffrast.ps1 must enable strict mode")
     require("$ErrorActionPreference = 'Stop'" in build_nvdiffrast, "build-nvdiffrast.ps1 must stop on errors")
+    require("Invoke-Expression" not in build_nvdiffrast, "build-nvdiffrast.ps1 must not construct commands via Invoke-Expression")
     require("pip wheel" in build_nvdiffrast and "--no-build-isolation" in build_nvdiffrast, "build-nvdiffrast.ps1 must build wheels via pip wheel --no-build-isolation")
     require("https://github.com/NVlabs/nvdiffrast.git" in build_nvdiffrast and "v0.4.0" in build_nvdiffrast, "build-nvdiffrast.ps1 must pin nvdiffrast source")
 
     build_diff = (ROOT / "native-wheels" / "scripts" / "build-diff-gaussian.ps1").read_text(encoding="utf-8")
     require("Set-StrictMode -Version Latest" in build_diff, "build-diff-gaussian.ps1 must enable strict mode")
     require("$ErrorActionPreference = 'Stop'" in build_diff, "build-diff-gaussian.ps1 must stop on errors")
+    require("Invoke-Expression" not in build_diff, "build-diff-gaussian.ps1 must not construct commands via Invoke-Expression")
     require("pip wheel" in build_diff and "--no-build-isolation" in build_diff, "build-diff-gaussian.ps1 must build wheels via pip wheel --no-build-isolation")
     require("https://github.com/autonomousvision/mip-splatting.git" in build_diff and "dda02ab5ecf45d6edb8c540d9bb65c7e451345a9" in build_diff, "build-diff-gaussian.ps1 must pin mip-splatting source")
     require("submodules/diff-gaussian-rasterization" in build_diff, "build-diff-gaussian.ps1 must build the diff-gaussian subdirectory")
     require("submodule update --init --recursive" in build_diff, "build-diff-gaussian.ps1 must initialize recursive submodules")
 
     smoke_test = (ROOT / "native-wheels" / "scripts" / "smoke-test.ps1").read_text(encoding="utf-8")
+    require("Invoke-Expression" not in smoke_test, "smoke-test.ps1 must not construct commands via Invoke-Expression")
     require("import torch; import nvdiffrast.torch; import diff_gaussian_rasterization" in smoke_test, "smoke-test.ps1 must validate torch and native imports")
 
     nvdiffrast_license = (ROOT / "native-wheels" / "licenses" / "nvdiffrast-LICENSE.txt").read_text(encoding="utf-8")