test: make csf.pl easier to unit test

Author: zeroth-blip

.github/tests/lib/TestCSFScript.pm

@@ -0,0 +1,42 @@
+package TestCSFScript;
+
+use strict;
+use warnings;
+
+use Exporter qw(import);
+use File::Spec;
+use TestBootstrap qw(repo_root);
+
+our @EXPORT_OK = qw(load_csf_pl);
+
+sub _install_stubs {
+    {
+        no warnings 'once';
+        package ConfigServer::Config;
+        sub import { return }
+        sub loadconfig { bless {}, __PACKAGE__ }
+        sub get_config { return '' }
+        sub config { return () }
+        sub ipv4reg { return qr/(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)/ }
+        sub ipv6reg { return qr/[0-9A-Fa-f:]+/ }
+    }
+    $INC{'ConfigServer/Config.pm'} = __FILE__;
+
+    {
+        no warnings 'once';
+        package ConfigServer::URLGet;
+        sub import { return }
+        sub urlget { return }
+    }
+    $INC{'ConfigServer/URLGet.pm'} = __FILE__;
+}
+
+sub load_csf_pl {
+    _install_stubs();
+    my $script = File::Spec->catfile( repo_root(), 'csf.pl' );
+    my $loaded = do $script;
+    die $@ || $! unless $loaded;
+    return $script;
+}
+
+1;

.github/tests/unit/csf_dogrep.t

@@ -0,0 +1,69 @@
+#!/usr/bin/env perl
+
+BEGIN {
+    *CORE::GLOBAL::exit = sub { die "unexpected exit(@_)" };
+}
+
+use strict;
+use warnings;
+
+use FindBin qw($Bin);
+use File::Spec;
+use lib File::Spec->catdir( $Bin, '..', 'lib' );
+
+use Test::More;
+use TestCSFScript qw(load_csf_pl);
+
+load_csf_pl();
+
+my @warnings;
+local $SIG{__WARN__} = sub { push @warnings, @_ };
+
+{
+    no warnings 'once';
+    no warnings 'redefine';
+
+    local %sbin::csf::config = (
+        IPTABLES     => '/sbin/iptables',
+        IPTABLESWAIT => '',
+        NAT          => 0,
+        MANGLE       => 0,
+        RAW          => 0,
+        IPV6         => 0,
+        LF_IPSET     => 0,
+    );
+    local $sbin::csf::verbose = 0;
+    local $sbin::csf::cleanreg = qr/[\r\n]+/;
+
+    local *sbin::csf::run_open3 = sub {
+        my $output = "Chain INPUT (policy ACCEPT)\n";
+        open my $fh, '<', \$output or die $!;
+        $_[0] = undef;
+        $_[1] = $fh;
+        $_[2] = $fh;
+        return -1;
+    };
+
+    local *sbin::csf::slurpee = sub {
+        my ($path) = @_;
+        return ( '', '0|1.2.3.4|80|in|600|note' ) if $path =~ /csf\.tempallow$/;
+        return ( '', '0|1.2.3.4|80|in|600|note' ) if $path =~ /csf\.tempban$/;
+        return ('') if $path =~ /csf\.(allow|deny)$/;
+        return;
+    };
+
+    local *sbin::csf::slurp = sub {
+        my ($path) = @_;
+        return ('') if $path =~ /csf\.(allow|deny)$/;
+        return;
+    };
+
+    local *sbin::csf::checkip = sub { return };
+
+    my $ok = eval { sbin::csf::dogrep('1.2.3.4'); 1 };
+    ok( $ok, 'dogrep handles blank temp allow/deny lines without dying' ) or diag $@;
+}
+
+is_deeply( \@warnings, [], 'dogrep emits no warnings for blank temp allow/deny lines' );
+
+done_testing;

.github/tests/unit/csf_modulino.t

@@ -0,0 +1,29 @@
+#!/usr/bin/env perl
+
+BEGIN {
+    *CORE::GLOBAL::exit = sub { die "unexpected exit(@_)" };
+}
+
+use strict;
+use warnings;
+
+use FindBin qw($Bin);
+use File::Spec;
+use lib File::Spec->catdir( $Bin, '..', 'lib' );
+
+use Test::More;
+use TestBootstrap qw(repo_root);
+use TestCSFScript qw(load_csf_pl);
+
+my $script = File::Spec->catfile( repo_root(), 'csf.pl' );
+local @ARGV = ('__should_not_run__');
+
+my $loaded = eval { load_csf_pl(); 1 };
+ok( $loaded, 'csf.pl loads successfully as a modulino' ) or diag $@ || $!;
+can_ok( 'sbin::csf', qw(run run_open3 process_input) );
+{
+    no warnings 'once';
+    ok( !defined $sbin::csf::input{command}, 'loading csf.pl does not execute top-level dispatch' );
+}
+
+done_testing;

.github/tests/unit/csf_process_input.t

@@ -0,0 +1,41 @@
+#!/usr/bin/env perl
+
+BEGIN {
+    *CORE::GLOBAL::exit = sub { die "unexpected exit(@_)" };
+}
+
+use strict;
+use warnings;
+
+use FindBin qw($Bin);
+use File::Spec;
+use lib File::Spec->catdir( $Bin, '..', 'lib' );
+
+use Test::More;
+use TestCSFScript qw(load_csf_pl);
+
+load_csf_pl();
+
+{
+    no warnings 'once';
+    local %sbin::csf::input;
+    local @ARGV = ( '--ADD', '1.2.3.4', 'with', 'comment' );
+
+    sbin::csf::process_input();
+
+    is( $sbin::csf::input{command}, '--add', 'process_input lowercases the command' );
+    is( $sbin::csf::input{argument}, '1.2.3.4 with comment', 'process_input joins remaining args into argument' );
+}
+
+{
+    no warnings 'once';
+    local %sbin::csf::input;
+    local @ARGV = ('--help');
+
+    sbin::csf::process_input();
+
+    is( $sbin::csf::input{command}, '--help', 'single-argument command is preserved' );
+    ok( !defined $sbin::csf::input{argument}, 'single-argument command leaves argument undefined' );
+}
+
+done_testing;