Adds variant details to split_details endpoint (#45)

add variant details to respective feature tests and modify split show
page view

Author: agirlnamedsophia

app/assets/stylesheets/components/_tables.scss

@@ -1,15 +1,21 @@
 .BasicTable {
   @include standard-table(100%, 40%, 25%);
-  max-width: $app-width;
-  margin-top: 0;
+}
 
-  thead tr th {
-    text-transform: capitalize;
-  }
+.DescriptionTable {
+  @include standard-table(100%, 15%, 45%);
 }
 
 .EmptyTable {
   &--centered {
     text-align: center;
   }
 }
+
+table {
+  max-width: $app-width;
+  margin-top: 0;
+  thead tr th {
+    text-transform: capitalize;
+  }
+}

app/models/split_detail.rb

@@ -4,7 +4,7 @@ class SplitDetail
   include DelegateAttribute
 
   attr_accessor :split
-  delegate :name, to: :split
+  delegate :name, :variant_details, to: :split
   delegate_attribute :hypothesis, :assignment_criteria, :description, :owner, :location, :platform, to: :split
 
   validates :hypothesis, :assignment_criteria, :description, :owner, :location, :platform, presence: true

app/views/admin/splits/_test_overview.html.erb

@@ -11,7 +11,7 @@
 
   <hr class="InfoCard-divider">
   <% if split.has_details? %>
-    <table class="BasicTable borderless bottom">
+    <table class="DescriptionTable borderless bottom">
       <tr>
         <td>Squad Owner</td>
         <td><%= split.owner %></td>

app/views/admin/splits/_variants.html.erb

@@ -5,20 +5,19 @@
   </div>
   <hr class="InfoCard-divider">
   <div class="InfoCard-description">
-    <table class="fs-VariantsTable BasicTable">
+    <table class="fs-VariantsTable DescriptionTable">
       <thead>
         <th>Name</th>
-        <th>Weight</th>
-        <th>Assignee Count</th>
+        <th>Description</th>
+        <th>Weight (Assignee Count)</th>
         <th></th>
       </thead>
       <tbody>
         <% split.variant_details.each do |variant_detail| %>
           <tr>
-            <td><%= variant_detail.variant %></td>
-            <td><%= variant_detail.weight %>%</td>
-            <td>
-              <%= variant_detail.assignment_count %>
+            <td><%= variant_detail.display_name %></td>
+            <td><%= variant_detail.description %></td>
+            <td><%= variant_detail.weight %>%(<%= variant_detail.assignment_count %>)
               <% if variant_detail.retirable? %>
               (<%= link_to "Retire variant", admin_split_variant_retirement_path(split, variant_detail.variant),
                 class: "retire-variant-link",

app/views/api/v1/split_details/_variant_detail.json.jbuilder

@@ -0,0 +1,2 @@
+json.name variant_detail.display_name
+json.description variant_detail.description

app/views/api/v1/split_details/show.json.jbuilder

@@ -1 +1,2 @@
 json.(@split_detail, :name, :hypothesis, :assignment_criteria, :description, :owner, :location, :platform)
+json.variant_details @split_detail.variant_details, partial: 'variant_detail', as: :variant_detail

spec/features/admin_split_config_create_spec.rb

@@ -14,7 +14,7 @@
   it 'allows admins to change the weights of a split' do
     split_page.load split_id: split.id
     expect(split_page).to be_displayed
-    expect(split_page.variants_table).to have_content "red 100% 0 edit blue 0% 0 edit"
+    expect(split_page.variants_table).to have_content "red 100%(0) edit blue 0%(0) edit"
 
     split_page.change_weights.click
 
@@ -46,6 +46,6 @@
       end
       form.submit_button.click
     end
-    expect(split_page.variants_table).to have_content "red 50% 0 edit blue 50% 0 edit"
+    expect(split_page.variants_table).to have_content "red 50%(0) edit blue 50%(0) edit"
   end
 end

spec/features/admin_variant_details_edit_spec.rb

@@ -25,5 +25,7 @@
 
     expect(split_page).to be_displayed
     expect(split_page).to have_content 'Details for enabled have been saved'
+    expect(split_page.variants.first.name).to have_content "Variant name"
+    expect(split_page.variants.first.description).to have_content "Super great variant"
   end
 end

spec/features/admin_variant_retirement_create_spec.rb

@@ -17,11 +17,11 @@
   it 'allows admins to retire a variant' do
     split_page.load split_id: split.id
     expect(split_page).to be_displayed
-    expect(split_page.variants_table).to have_content "blue 0% 8 (Retire variant)"
+    expect(split_page.variants_table).to have_content "blue 0%(8) (Retire variant)"
 
     split_page.retire_variant.click
 
-    expect(split_page.variants_table).to have_content "blue 0% 0"
+    expect(split_page.variants_table).to have_content "blue 0%(0)"
     expect(split_page.variants_table).not_to have_content "Retire variant"
   end
 end

spec/requests/api/v1/split_details_spec.rb

@@ -4,7 +4,26 @@
   describe 'GET /api/v1/split_details/:id' do
     let(:default_app) { FactoryGirl.create :app, name: "default_app", auth_secret: "6Sd6T7T6Q8hKcoo0t8CTzV0IdN1EEHqXB2Ig4raZsOf" }
     let(:split_with_no_details) { FactoryGirl.create :split, name: "fantastic_split" }
-    let(:split_with_details) { FactoryGirl.create :split, name: "fantastic_split_with_information", platform: 'mobile', description: 'Greatest Split', assignment_criteria: "Must love problem solvers", hypothesis: 'Will solve all problems', location: 'Everywhere', owner: 'Me' } # rubocop:disable Metrics/LineLength
+    let(:split_with_details) { FactoryGirl.create :split, registry: { enabled: 99, disabled: 1 }, name: "fantastic_split_with_information", platform: 'mobile', description: 'Greatest Split', assignment_criteria: "Must love problem solvers", hypothesis: 'Will solve all problems', location: 'Everywhere', owner: 'Me' } # rubocop:disable Metrics/LineLength
+
+    let!(:variant_detail_a) do
+      FactoryGirl.create(
+        :variant_detail,
+        split: split_with_details,
+        variant: 'enabled',
+        display_name: 'fantastic_split_with_information is on',
+        description: 'This awesome feature makes cool stuff happen.'
+      )
+    end
+    let!(:variant_detail_b) do
+      FactoryGirl.create(
+        :variant_detail,
+        split: split_with_details,
+        variant: 'disabled',
+        display_name: 'fantastic_split_with_information is off',
+        description: 'This feature makes nothing happen.'
+      )
+    end
 
     before do
       http_authenticate username: default_app.name, password: default_app.auth_secret
@@ -20,7 +39,8 @@
         "assignment_criteria" => nil,
         "platform" => nil,
         "description" => nil,
-        "owner" => nil
+        "owner" => nil,
+        "variant_details" => []
       )
     end
 
@@ -34,7 +54,17 @@
         "assignment_criteria" => split_with_details.assignment_criteria,
         "platform" => split_with_details.platform,
         "description" => split_with_details.description,
-        "owner" => split_with_details.owner
+        "owner" => split_with_details.owner,
+        "variant_details" => [
+          {
+            "name" => "fantastic_split_with_information is on",
+            "description" => 'This awesome feature makes cool stuff happen.'
+          },
+          {
+            "name" => "fantastic_split_with_information is off",
+            "description" => "This feature makes nothing happen."
+          }
+        ]
       )
     end