Skip to content

Commit d8875ac

Browse files
authored
chore: Pin Github Actions to Commit Hashes (#64)
This PR includes automated changes from running [frizbee](https://github.com/stacklok/frizbee) to pin Github Actions. For more information on what this actually means, take a look at [our documentation on UnpinnedActions](https://github.com/betterment/claws?tab=readme-ov-file#unpinnedactions). Because `frizbee` will be replacing tags with their corresponding commit hash, this change should fundamentally be a no-op. This change just makes our code more explicit about what we're using. Note that because we're touching Github Workflow files in this PR, there is a chance that [Claws](https://github.com/betterment/claws), our GHA Static Analyzer, will find other issues in those files that were introduced before this PR was created. These findings will need to be addressed before this PR can be merged. The Claws documentation has a good list for how to remediate each type of finding, but for brevity, here are some of the commonly seen ones: * RiskyTriggers: Fires when a workflow has workflow_dispatch or pull_request_target; remediate by leaving comments explaning why, and put an ignore statement ([example](https://github.com/Betterment/retail/blob/92e76923f4e5d51e8386301538e383883cd5eb57/.github/workflows/create_datadog_slo.yml#L2-L4)) * UnsafeCheckout: Fires when a workflow checks out user supplied code; remediate by leaving a comment explaining how the user supplied code is used and confirm it isn't executed ([example](https://github.com/Betterment/linda-test/blob/6cd5954c7c1d2bdb781239b6686b3a5dcbcd6fda/.github/workflows/claws_fork_friendly.yml#L50-L54)) For other findings and how to remediate them, check the [Claws docs!](https://github.com/betterment/claws?tab=readme-ov-file#built-in-rules)
1 parent 61a0a3b commit d8875ac

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/linter.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ jobs:
77
runs-on: ubuntu-latest
88

99
steps:
10-
- uses: actions/checkout@v2
11-
- uses: ruby/setup-ruby@v1
10+
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
11+
- uses: ruby/setup-ruby@a4effe49ee8ee5b8b5091268c473a4628afb5651 # v1
1212
with:
1313
ruby-version: 3.2
1414
bundler-cache: true

.github/workflows/tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ jobs:
2424
- ruby: '3.0'
2525
gemfile: gemfiles/rails_8_0.gemfile
2626
steps:
27-
- uses: actions/checkout@v2
27+
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
2828
- name: Setup Chrome
29-
uses: browser-actions/setup-chrome@latest
29+
uses: browser-actions/setup-chrome@c785b87e244131f27c9f19c1a33e2ead956ab7ce # latest
3030
with:
3131
chrome-version: stable
32-
- uses: ruby/setup-ruby@v1
32+
- uses: ruby/setup-ruby@a4effe49ee8ee5b8b5091268c473a4628afb5651 # v1
3333
env:
3434
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
3535
with:

0 commit comments

Comments
 (0)