Skip to content

Commit 200beb5

Browse files
committed
Default to 0 (until v1.0) and document in README
1 parent f8ac334 commit 200beb5

3 files changed

Lines changed: 9 additions & 1 deletion

File tree

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,10 @@ Delayed::Worker.read_ahead = 5
432432

433433
# If a worker finds no jobs, it will sleep this number of seconds in between attempts:
434434
Delayed::Worker.sleep_delay = 5
435+
436+
# Until version 1.0, the worker will not sleep at all between attemps if it finds jobs.
437+
# This can be configured by setting the minimum reserve interval:
438+
Delayed::Worker.min_reserve_interval = 0.5 # seconds
435439
```
436440

437441
If a job fails, it will be rerun up to 25 times (with an exponential back-off). Jobs will also

lib/delayed/worker.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class Worker
1212
include Runnable
1313

1414
cattr_accessor :sleep_delay, instance_writer: false, default: 5
15-
cattr_accessor :min_reserve_interval, instance_writer: false, default: 1
15+
cattr_accessor :min_reserve_interval, instance_writer: false, default: 0
1616
cattr_accessor :max_attempts, instance_writer: false, default: 25
1717
cattr_accessor :max_claims, instance_writer: false, default: 5
1818
cattr_accessor :max_run_time, instance_writer: false, default: 20.minutes

spec/helper.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,10 @@ class SingletonClass
120120
sleep_delay_was = Delayed::Worker.sleep_delay
121121
min_reserve_interval_was = Delayed::Worker.min_reserve_interval
122122

123+
if Gem.loaded_specs['delayed'].version >= Gem::Version.new('1.0') && min_reserve_interval_was.zero?
124+
raise "Min reserve interval should be nonzero in v1.0 release"
125+
end
126+
123127
Delayed::Worker.sleep_delay = TEST_SLEEP_DELAY
124128
Delayed::Worker.min_reserve_interval = TEST_MIN_RESERVE_INTERVAL
125129

0 commit comments

Comments
 (0)