Commit 97f6350
authored
Add explicit codeowners line for who can approve extension publishing (#9155)
Prep for adding in Foundry developers so they can also approve their own registry update PRs, subject to the checks in the `ext-registry-check` workflow. (There's some github changes I need to do before I can add Foundry into CODEOWNERS, but this is very close!)
(small changes)
* Bring myself back as an azd reviewer.
* Adding myself to the global codeowners slot since everyone else is on that.
(these are those workflows, and it's js file):
- https://github.com/Azure/azure-dev/blob/main/.github/scripts/src/ext-registry-check.js
- https://github.com/Azure/azure-dev/blob/main/.github/workflows/ext-registry-check.yml
The way this works, with regards to registry PRs:
- Simple registry updates (new version for an existing extension, no provider or capability updates) can be approved by anyone in CODEOWNERS (azd team, foundry devs, currently).
- Complex updates (ie, any of those things mentioned above, change), you get a PR workflow fail for the "ext-registry-check" workflow run:
<img width="1324" height="113" alt="image" src="https://github.com/user-attachments/assets/f444dcb1-a1b3-452f-b72f-577e76902980" />
If you click it ([link](https://github.com/Azure/azure-dev/actions/runs/29439680201/job/87435127264?pr=9100)) it'll tell you the specific item that's requires approval. So then:
1. The user needs to find an azd core team member, and provided it's "okay" (@tg-msft is working on docs) then they'll approve it and the release can happen (the 'super approvers' list is just hardcoded in the JS at this moment: (https://github.com/Azure/azure-dev/blob/cc1f941a9a27098facdd95db0f4f47fc5241a3b6/.github/scripts/src/ext-registry-check.js#L143))
2. Re-run that failed workflow step - now it will pass.
Part of the fix for #89971 parent 8eb1a10 commit 97f6350
3 files changed
Lines changed: 33 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
148 | | - | |
149 | | - | |
| 148 | + | |
| 149 | + | |
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
3 | 14 | | |
4 | 15 | | |
5 | | - | |
6 | | - | |
7 | 16 | | |
8 | 17 | | |
9 | 18 | | |
| |||
26 | 35 | | |
27 | 36 | | |
28 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
29 | 52 | | |
| 53 | + | |
30 | 54 | | |
31 | 55 | | |
32 | 56 | | |
33 | 57 | | |
34 | 58 | | |
| 59 | + | |
35 | 60 | | |
36 | 61 | | |
37 | 62 | | |
| |||
0 commit comments