Skip to content

Commit 71f8623

Browse files
hemarinaJeffreyCACopilot
authored
Update Go to 1.26.4 and bump golang.org/x/crypto and golang.org/x/net (#8651)
* Update Go to 1.26.4 and bump golang.org/x/crypto and golang.org/x/net Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Replace Update-GoVersion scripts with a mage target Consolidate the repo-wide Go version sync logic into a single 'mage updateGoVersion <version>' target, removing the duplicated PowerShell and bash scripts that could drift apart. Repoint the validate-go-version workflow hint and document the target in AGENTS.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Validate Go version format and make CI fix hint copy/pasteable Address PR review feedback: require a bare X.Y.Z version in the mage updateGoVersion target to guard against typos, and embed 'cd cli/azd' in the validate-go-version error hint so it can be pasted directly from the CI log. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jeffrey Chen <jeffreychen@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 37e32af commit 71f8623

23 files changed

Lines changed: 166 additions & 131 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
44
"features": {
55
"ghcr.io/devcontainers/features/go:1": {
6-
"version": "1.26.1"
6+
"version": "1.26.4"
77
},
88
"ghcr.io/devcontainers/features/docker-in-docker:2.11.0": {
99
"version": "latest",

.github/workflows/validate-go-version.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ jobs:
8383
8484
echo ""
8585
if [ "$ERRORS" -gt 0 ]; then
86-
echo "::error::$ERRORS Go version mismatch(es) found. Run 'pwsh eng/scripts/Update-GoVersion.ps1 -NewVersion $EXPECTED' to fix."
86+
echo "::error::$ERRORS Go version mismatch(es) found. Run 'cd cli/azd && mage updateGoVersion $EXPECTED' to fix."
8787
exit 1
8888
fi
8989
echo "All Go versions are consistent ($EXPECTED)."

cli/azd/AGENTS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ Additional mage targets:
7979

8080
- `mage record` — re-record functional test cassettes against a live Azure subscription. Accepts an optional `-filter=TestName` flag to re-record specific tests. Typically only core maintainers need to run this; external contributors can rely on playback mode (the default) which requires no Azure access. Requires `azd auth login` and a configured test subscription (see `docs/recording-functional-tests-guide.md`).
8181
- `mage coverage:pr` — preview the CI PR coverage gate locally before pushing. Resolves PR-touched `.go` files via `git merge-base origin/main HEAD` for the per-package summary, runs the diff against the latest `main` baseline, and fails (exit 2) on **either** breach type: any PR-touched package drops more than 0.5 pp, or overall coverage falls below 69% (defaults match CI; override via `COVERAGE_MAX_PACKAGE_DECREASE`, `COVERAGE_MIN_OVERALL`). See `docs/code-coverage-guide.md` for details.
82+
- `mage updateGoVersion <version>` — bump the pinned Go toolchain version everywhere it is referenced (every `cli/azd` `go.mod`, the ADO `setup-go` template, Dockerfiles, and the devcontainer Go feature). `cli/azd/go.mod` is the source of truth enforced by the `validate-go-version` workflow. This is the single source of truth for the sync logic. Example: `mage updateGoVersion 1.26.4`.
8283

8384
```bash
8485
gofmt -s -w .

cli/azd/extensions/azure.ai.agents/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module azureaiagent
22

3-
go 1.26.1
3+
go 1.26.4
44

55
require (
66
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.21.0

cli/azd/extensions/azure.ai.connections/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module azure.ai.connections
22

3-
go 1.26.1
3+
go 1.26.4
44

55
require (
66
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.20.0

cli/azd/extensions/azure.ai.finetune/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module azure.ai.finetune
22

3-
go 1.26.1
3+
go 1.26.4
44

55
require (
66
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.21.0

cli/azd/extensions/azure.ai.inspector/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module azureaiinspector
22

3-
go 1.26.1
3+
go 1.26.4
44

55
require (
66
github.com/azure/azure-dev/cli/azd v1.24.3

cli/azd/extensions/azure.ai.models/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module azure.ai.models
22

3-
go 1.26.1
3+
go 1.26.4
44

55
require (
66
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.20.0

cli/azd/extensions/azure.ai.projects/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module azure.ai.projects
22

3-
go 1.26.1
3+
go 1.26.4
44

55
require (
66
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.20.0

cli/azd/extensions/azure.ai.routines/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module azure.ai.routines
22

3-
go 1.26.1
3+
go 1.26.4
44

55
require (
66
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.20.0

0 commit comments

Comments
 (0)