Harden owner request packet parsing (#244)

8Dionysus · web-flow · commit 8c3d693371ad · 2026-06-15T17:13:11.000-06:00
diff --git a/scripts/owner_requests/validate_owner_request_docs.py b/scripts/owner_requests/validate_owner_request_docs.py
@@ -43,7 +43,7 @@ def load_json(path: Path) -> dict[str, Any]:
 
 def request_packet_body(text: str, request_id: str) -> str | None:
     match = re.search(
-        rf"^### {re.escape(request_id)}\n(?P<body>.*?)(?=^### |\Z)",
+        rf"^### {re.escape(request_id)}\n(?P<body>.*?)(?=^## |\Z)",
         text,
         re.MULTILINE | re.DOTALL,
     )
@@ -58,6 +58,7 @@ def receipt_backed_packet_section_problems(rel: str, text: str, requests: list[d
         request_id = str(req.get("id") or "")
         body = request_packet_body(text, request_id)
         if body is None:
+            problems.append(f"{rel}: {request_id} must have its own ready-to-carry packet section")
             continue
         if "receipt-backed" not in body.lower():
             problems.append(f"{rel}: {request_id} must distinguish its receipt-backed status")
diff --git a/tests/test_owner_request_docs.py b/tests/test_owner_request_docs.py
@@ -53,6 +53,52 @@ def test_receipt_backed_validation_is_packet_scoped(self):
             [],
         )
 
+    def test_receipt_backed_validation_requires_matching_packet_section(self):
+        module = load("validate_owner_request_docs", "scripts/owner_requests/validate_owner_request_docs.py")
+        text = """## Ready-to-carry packets
+
+| Request | Status |
+|---|---|
+| `ORQ-FAKE-SKILLS-001` | `landed` |
+
+### ORQ-FAKE-SKILLS-TYPO-001
+
+Receipt-backed status: `owner_landing_ref` and `owner_proof_ref` are linked here.
+"""
+        problems = module.receipt_backed_packet_section_problems(
+            "fake/OWNER_REQUESTS.md",
+            text,
+            [{"id": "ORQ-FAKE-SKILLS-001", "queue_status": "landed"}],
+        )
+        self.assertEqual(
+            problems,
+            ["fake/OWNER_REQUESTS.md: ORQ-FAKE-SKILLS-001 must have its own ready-to-carry packet section"],
+        )
+
+    def test_request_packet_body_stops_before_later_h2_sections(self):
+        module = load("validate_owner_request_docs", "scripts/owner_requests/validate_owner_request_docs.py")
+        text = """## Ready-to-carry packets
+
+### ORQ-FAKE-SKILLS-001
+
+Status: `landed`; owner receipt linked.
+
+## Center sources
+
+Receipt-backed status: `owner_landing_ref` and `owner_proof_ref` are generic later text.
+"""
+        body = module.request_packet_body(text, "ORQ-FAKE-SKILLS-001")
+        self.assertIsNotNone(body)
+        self.assertNotIn("## Center sources", body)
+        problems = module.receipt_backed_packet_section_problems(
+            "fake/OWNER_REQUESTS.md",
+            text,
+            [{"id": "ORQ-FAKE-SKILLS-001", "queue_status": "landed"}],
+        )
+        self.assertIn("fake/OWNER_REQUESTS.md: ORQ-FAKE-SKILLS-001 must distinguish its receipt-backed status", problems)
+        self.assertIn("fake/OWNER_REQUESTS.md: ORQ-FAKE-SKILLS-001 must name owner_landing_ref in its packet", problems)
+        self.assertIn("fake/OWNER_REQUESTS.md: ORQ-FAKE-SKILLS-001 must name owner_proof_ref in its packet", problems)
+
     def test_owner_request_protocol_declines_center_activation(self):
         text = (ROOT / "mechanics/OWNER_REQUEST_PROTOCOL.md").read_text(encoding="utf-8")
         self.assertIn("A request packet is not owner acceptance", text)
