Fix bug that finalizer is always configured

Author: EHJ-52n

src/pygeoapi_k8s_manager/manager.py

@@ -441,7 +441,7 @@ def create_job_body(p: KubernetesProcessor, job_id: str, data_dict: dict, add_fi
         spec=V1JobSpec(
             template=V1PodTemplateSpec(
                 # metadata=V1ObjectMeta(labels=job_pod_spec.extra_labels),
-                metadata=V1ObjectMeta(finalizers=[format_log_finalizer()] if add_finalizer is not None else None),
+                metadata=V1ObjectMeta(finalizers=[format_log_finalizer()] if add_finalizer else None),
                 spec=job_pod_spec.pod_spec,
             ),
             backoff_limit=0,

tests/test_manager.py

@@ -553,6 +553,12 @@ def test_create_job_body_sets_required_annotations(job_id, mocked_processor, mim
         assert job.metadata.annotations["pygeoapi.io/started"] == job.metadata.annotations["pygeoapi.io/updated"]
 
 
+def test_create_job_body_does_not_set_finalizer_if_setting_is_false(mocked_processor, job_id):
+    job = create_job_body(mocked_processor, job_id, {}, False)
+
+    assert job.spec.template.metadata.finalizers is None
+
+
 class KubernetesProcessorForTesting(KubernetesProcessor):
     def create_job_pod_spec(self, data, job_name):
         return KubernetesProcessor.JobPodSpec(V1PodSpec(containers=[V1Container(name="test-container")]), {})